Bump RESTIC_VERSION to 0.18.1-20260421#91
Conversation
Signed-off-by: Anisur Rahman <anisur@appscode.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the Restic version used by the build system, so produced binaries embed/build against the intended Restic release identifier.
Changes:
- Bump
RESTIC_VERin the Makefile to0.18.1-20260421. - Update the build container invocation to pass a Restic version value into
./hack/build.sh.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| commit_hash=$(commit_hash) \ | ||
| commit_timestamp=$(commit_timestamp) \ | ||
| RESTIC_VER=$(RESTIC_VER) \ | ||
| RESTIC_VER=0.18.1-20260421 |
There was a problem hiding this comment.
In the docker run recipe, the line that sets RESTIC_VER is missing the trailing \ line-continuation. This will terminate the docker run ... /bin/bash -c "..." command early with an unterminated quoted string, causing make build to fail. Add the continuation back (and keep the closing quote on the final line of the command).
| RESTIC_VER=0.18.1-20260421 | |
| RESTIC_VER=0.18.1-20260421 \ |
| commit_hash=$(commit_hash) \ | ||
| commit_timestamp=$(commit_timestamp) \ | ||
| RESTIC_VER=$(RESTIC_VER) \ | ||
| RESTIC_VER=0.18.1-20260421 |
There was a problem hiding this comment.
The build recipe now hardcodes RESTIC_VER=0.18.1-20260421 instead of using the $(RESTIC_VER) Make variable. This duplicates the version in two places and breaks the ability to override RESTIC_VER from the environment/CLI (only the variable assignment would change). Use RESTIC_VER=$(RESTIC_VER) here to keep a single source of truth.
| RESTIC_VER=0.18.1-20260421 | |
| RESTIC_VER=$(RESTIC_VER) \ |
| BUILD_IMAGE ?= ghcr.io/appscode/golang-dev:$(GO_VERSION) | ||
|
|
||
| RESTIC_VER := 0.18.1 | ||
| RESTIC_VER := 0.18.1-20260421 |
There was a problem hiding this comment.
PR title/description says "RESTIC_VERSION", but the Makefile variable being updated is RESTIC_VER. If the automation/reporting expects a specific variable name, consider aligning the wording (or renaming the variable consistently) to avoid confusion about what was actually bumped.
Automated update of RESTIC_VERSION