Skip to content

🐛 Remove static TODO banner from analytics page#2172

Merged
clubanderson merged 1 commit intomainfrom
fix/remove-analytics-todo
Mar 11, 2026
Merged

🐛 Remove static TODO banner from analytics page#2172
clubanderson merged 1 commit intomainfrom
fix/remove-analytics-todo

Conversation

@clubanderson
Copy link
Contributor

@clubanderson clubanderson commented Mar 11, 2026

Summary

  • Removed the hardcoded TODO banner about "error rate" from the analytics page (/analytics)
  • The banner was a static developer note that always displayed, regardless of actual error rate
  • GA4 events are flowing normally (verified via GA4 API — ~17K events in the last 7 days)

Test plan

  • Visit console.kubestellar.io/analytics and verify the yellow TODO banner is gone
  • Verify KPI cards and charts still render correctly

@clubanderson
🐛 Remove static TODO banner from analytics page
63bb0b5 
The TODO banner about error rate was a static developer note that always
displayed regardless of actual error rate. GA4 events are flowing fine,
so this was unnecessary user-facing noise.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings March 11, 2026 03:43
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Mar 11, 2026
@kubestellar-prow
Copy link
Contributor

kubestellar-prow bot commented Mar 11, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Mar 11, 2026 •
edited
Loading

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 63bb0b5
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69b0e4e53ba9380008115793
😎 Deploy Preview https://deploy-preview-2172.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@clubanderson clubanderson merged commit c54858c into main Mar 11, 2026
12 of 13 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request.

Before your PR can be merged, please ensure:

✅ DCO Sign-off - All commits must be signed off with git commit -s to certify the Developer Certificate of Origin

✅ PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), ⚠️ (breaking change)

Getting Started with KubeStellar:

Contributor Resources:

🌟 Help KubeStellar Grow - We Need Adopters!

Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes:

📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction!

A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack!

@kubestellar-prow kubestellar-prow bot deleted the fix/remove-analytics-todo branch March 11, 2026 03:43
@kubestellar-prow kubestellar-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 11, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

🎉 Thank you for your contribution! Your PR has been successfully merged.

🌟 Help KubeStellar Grow - We Need Adopters!

Our roadmap is driven entirely by adopter feedback - nothing else. Whether you're using KubeStellar yourself or know organizations that could benefit from multi-cluster Kubernetes, we need your help:

📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction!

🗣️ Spread the word - Tell colleagues, write blog posts, present at meetups

💬 Share feedback on Slack #kubestellar-dev

Every adopter story helps us prioritize what matters most. Thank you for being part of the KubeStellar community!

Copilot AI reviewed Mar 11, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a hardcoded developer TODO banner from the static /analytics page so the UI no longer shows a persistent warning unrelated to actual analytics health.

Changes:

  • Deleted the .todo-banner CSS block from analytics.html.
  • Removed the JavaScript that always injected the “TODO: Address error rate” banner into the rendered dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clubanderson