✨ Restore scroll position and route on login#218
Conversation
Navigate directly to the last visited dashboard route after login instead of going to '/' first (avoids flash). Also enhance scroll position persistence with card-based identity restore, which is robust across layout shifts caused by lazy-loaded dashboard cards. Key changes: - AuthCallback: Use getLastRoute() to navigate to last dashboard - Save card title (h3) alongside pixel position for identity-based restore - Add debounced scroll listener to capture position before sign-out - Prevent scroll save during active restoration (isRestoringRef) - Detect content-still-loading state to avoid premature stabilization Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Signed-off-by: Andrew Anderson <andy@clubanderson.com>
kubestellar-prow
bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Welcome to KubeStellar! 🚀 Thank you for submitting this Pull Request. Before your PR can be merged, please ensure: ✅ DCO Sign-off - All commits must be signed off with ✅ PR Title - Must start with an emoji: ✨ (feature), 🐛 (bug fix), 📖 (docs), 🌱 (infra/tests), Getting Started with KubeStellar: Contributor Resources:
🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback. Whether you're using KubeStellar yourself or know someone who could benefit from multi-cluster Kubernetes: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! A maintainer will review your PR soon. Feel free to ask questions in the comments or on Slack! |
kubestellar-prow
bot
added
the
size/L
|
🎉 Thank you for your contribution! Your PR has been successfully merged. 🌟 Help KubeStellar Grow - We Need Adopters! Our roadmap is driven entirely by adopter feedback - nothing else. Whether you're using KubeStellar yourself or know organizations that could benefit from multi-cluster Kubernetes, we need your help: 📋 Take our Multi-Cluster Survey - Share your use cases and help shape our direction! 🗣️ Spread the word - Tell colleagues, write blog posts, present at meetups 💬 Share feedback on Slack #kubestellar-dev Every adopter story helps us prioritize what matters most. Thank you for being part of the KubeStellar community! |
❌ Playwright Tests Failed📊 View Full ReportDownload the To view the report locally: # Download and extract playwright-report.zip
npx playwright show-report path/to/playwright-report |
Navigate directly to the last visited dashboard route after login instead of going to '/' first (avoids flash). Also enhance scroll position persistence with card-based identity restore, which is robust across layout shifts caused by lazy-loaded dashboard cards. Key changes: - AuthCallback: Use getLastRoute() to navigate to last dashboard - Save card title (h3) alongside pixel position for identity-based restore - Add debounced scroll listener to capture position before sign-out - Prevent scroll save during active restoration (isRestoringRef) - Detect content-still-loading state to avoid premature stabilization Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 participant
Summary
Test plan
🤖 Generated with Claude Code