Extract hardcoded user-facing strings to i18n translation keys#3789
Extract hardcoded user-facing strings to i18n translation keys#3789clubanderson merged 3 commits intomainfrom
Conversation
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hey @Copilot — thanks for opening this PR!
This is an automated message. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Fixes #438 - extracts 25+ hardcoded strings from JSX components into the existing react-i18next translation system. Signed-off-by: GitHub Copilot <copilot@github.com> Agent-Logs-Url: https://github.com/kubestellar/console/sessions/447ea707-f1fe-4a7a-9934-2cf768590425 Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>
Two strings were missed in the initial extraction:
- "Optimization recommendations" -> t('drilldown.buildpack.optimizationRecommendations')
- "Click \"Analyze Buildpack\"..." -> t('drilldown.buildpack.clickAnalyze')
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
acc7f0a to
b8e3eba
Compare
|
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff: DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
25+ hardcoded JSX strings identified by Auto-QA were not routed through the existing
react-i18nexttranslation system, making them untranslatable.📌 Fixes
📝 Summary of Changes
Extracts all flagged hardcoded strings into
web/src/locales/en/common.jsonand replaces inline text witht()calls across 11 components. No new i18n infrastructure — uses the existinguseTranslationhook already present in most files.Changes Made
common.jsonin existing sections (gpu,common,settings.localClusters) and new drilldown subsections (kustomization,policy,nodeDetail,alertDetail,buildpack)history.configurationUpdatedkey; renamed unused_t→tinCardHistory.tsxandCardConfigModal.tsxuseTranslationimport + hook toBuildpackDrillDown.tsx(was missing entirely)Custom,Health,Provider) inFilterTabs.tsxGPUDetailModal,NamespaceResources,LocalClustersSectionKustomizationDrillDown,PolicyDrillDown,NodeDrillDown,AlertDrillDown,BuildpackDrillDown)Pattern applied consistently:
Checklist
git commit -s)Screenshots or Logs (if applicable)
N/A — string extraction only; no visual changes.
👀 Reviewer Notes
All lint errors in modified files (
AlertDrillDown,KustomizationDrillDown,LocalClustersSection) are pre-existingreact-hooks/immutabilityviolations unrelated to this PR.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.