🐛 Remove active users widget from navbar, widen agent setup modal#4007
🐛 Remove active users widget from navbar, widen agent setup modal#4007clubanderson merged 1 commit intomainfrom
Conversation
- Remove ActiveUsersWidget from both desktop and mobile navbar - Widen AgentSetupDialog from md to lg so button text isn't cramped Signed-off-by: Andrew Anderson <andy@clubanderson.com>
kubestellar-prow
bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kubestellar-prow
bot
added
the
size/XS
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
There was a problem hiding this comment.
Pull request overview
Removes the active users indicator from the top navigation and adjusts the agent setup modal sizing to improve button spacing.
Changes:
- Removed
ActiveUsersWidgetfrom both desktop and mobile navbar layouts. - Changed
AgentSetupDialogmodal size frommdtolg.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/src/components/layout/navbar/Navbar.tsx | Removes ActiveUsersWidget from navbar UI (desktop + mobile overflow). |
| web/src/components/agent/AgentSetupDialog.tsx | Updates modal sizing to provide more space for footer actions. |
|
|
||
| return ( | ||
| <BaseModal isOpen={show} onClose={() => handleDismiss(false)} size="md"> | ||
| <BaseModal isOpen={show} onClose={() => handleDismiss(false)} size="lg"> |
There was a problem hiding this comment.
Changing BaseModal size from md to lg affects both width and height (BaseModal.tsx maps lg to max-w-4xl and min-h-[80vh]). If the goal is only to widen the dialog for footer button spacing, this may unintentionally create a very tall modal with lots of empty space / extra scrolling on smaller viewports. Consider keeping size="md" and widening via className (e.g., a larger max-w-*), or extend BaseModal to separate width and height sizing so you can widen without increasing min-height.
| <BaseModal isOpen={show} onClose={() => handleDismiss(false)} size="lg"> | |
| <BaseModal isOpen={show} onClose={() => handleDismiss(false)} className="max-w-4xl"> |
🔄 Auto-Applying Copilot Code ReviewCopilot code review found 1 code suggestion(s) and 0 general comment(s). @copilot Please apply all of the following code review suggestions:
Push all fixes in a single commit. Run Auto-generated by copilot-review-apply workflow. |
Summary
ActiveUsersWidgetfrom both desktop and mobile navbar layoutsAgentSetupDialogfrommdtolgso footer buttons aren't crampedTest plan