🐛 Fix GitHub repo tree to show file contents instead of empty by clubanderson · Pull Request #4063 · kubestellar/console

clubanderson · 2026-04-01T02:08:46Z

Summary

Root cause fix for "Empty" showing when expanding watched GitHub repos in the Mission Explorer.

toggleNode for github source nodes was always calling /api/github/repos?hasMissionsDir=true — this lists the user's repos, which is correct for the root "My Repositories" node but wrong for a child repo like sample-runbooks. Now distinguishes by node ID:

Root (id=github): lists user repos
Child repo: calls /api/github/repos/{owner}/{repo}/contents via the GitHub Contents API proxy, filtered to mission file extensions

Test plan

Add clubanderson/sample-runbooks → expand → should show 9 files (YAML + MD)
Files should appear as tree children, not "Empty"

toggleNode for github source nodes was always calling /api/github/repos?hasMissionsDir=true regardless of whether the node is the root "My Repositories" or a child repo. Now distinguishes: - Root node (id=github): lists user's repos - Child repo node: lists repo contents via GitHub Contents API This was the root cause of "Empty" for watched GitHub repos. Signed-off-by: Andrew Anderson <andy@clubanderson.com>

kubestellar-prow · 2026-04-01T02:08:51Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-04-01T02:08:52Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`7f71380`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/69cc7e311a2f2f0008e6504e
😎 Deploy Preview	https://deploy-preview-4063.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-04-01T02:08:54Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

github-actions · 2026-04-01T02:08:57Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Copilot

Pull request overview

Fixes the Mission Explorer GitHub repo tree expansion so watched repository nodes fetch and display repository contents (mission-relevant files/directories) instead of listing repos again and showing “Empty”.

Changes:

Updated toggleNode to distinguish the GitHub root node (id=github) from child repo nodes.
For child repo nodes, fetches repo contents via the GitHub Contents API proxy and filters to mission file extensions + directories.

Copilot · 2026-04-01T02:14:14Z

web/src/components/missions/MissionBrowser.tsx

+            const repoPath = node.path
+            const { data: ghEntries } = await api.get<Array<{ name: string; path: string; type: string; size?: number }>>(
+              `/api/github/repos/${repoPath}/contents`


repoPath is taken from node.path and interpolated into /api/github/repos/${repoPath}/contents. Once a repo has been expanded, directory nodes will have node.path like owner/repo/someDir, which produces a proxy call to /repos/owner/repo/someDir/contents (not a valid GitHub Contents API route). Parse node.path into owner, repo, and an optional subPath, and call the Contents endpoint as /api/github/repos/${owner}/${repo}/contents/${subPath} (root should use an empty subPath with a trailing slash). Also consider applying the same fix to the similar GitHub directory listing code in selectNode.

Suggested change

const repoPath = node.path

const { data: ghEntries } = await api.get<Array<{ name: string; path: string; type: string; size?: number }>>(

`/api/github/repos/${repoPath}/contents`

const pathParts = node.path.split('/')

const [owner, repo, ...subPathParts] = pathParts

const subPath = subPathParts.join('/')

const repoPath = `${owner}/${repo}`

const contentsUrl = subPath

? `/api/github/repos/${owner}/${repo}/contents/${subPath}`

: `/api/github/repos/${owner}/${repo}/contents/`

const { data: ghEntries } = await api.get<Array<{ name: string; path: string; type: string; size?: number }>>(

contentsUrl

Copilot · 2026-04-01T02:14:15Z

web/src/components/missions/MissionBrowser.tsx

+          if (nodeId === 'github') {
+            // Root "My Repositories" — list user's repos
+            const { data: repos } = await api.get<Array<{ name: string; full_name: string }>>(
+              '/api/github/repos?hasMissionsDir=true'


The root branch uses /api/github/repos?hasMissionsDir=true, but the backend GitHub proxy only allows /repos/, /rate_limit, /user, and /notifications (see pkg/api/handlers/github_proxy.go), so /api/github/repos (no trailing slash / no owner+repo) will be rejected with 403. Also, the root github node is initialized with loaded: true, so this fetch path is currently unreachable. Either remove this branch, or change the root node loading strategy and use a valid GitHub API endpoint (e.g. /api/github/user/repos) with client-side filtering.

Suggested change

'/api/github/repos?hasMissionsDir=true'

'/api/github/user/repos?hasMissionsDir=true'

Copilot · 2026-04-01T02:14:15Z

web/src/components/missions/MissionBrowser.tsx

+            children = (ghEntries || [])
+              .filter(e => e.type === 'dir' || isMissionFile(e.name))
+              .map(e => ({
+                id: `${nodeId}/${e.name}`,
+                name: e.name,
+                path: `${repoPath.split('/').slice(0, 2).join('/')}/${e.path}`,
+                type: (e.type === 'dir' ? 'directory' : 'file') as TreeNode['type'],
+                source: 'github' as const,
+                loaded: e.type !== 'dir',
+                description: e.size ? `${e.size} bytes` : undefined,
+              }))


MissionBrowser has unit tests, but the new GitHub tree expansion behavior isn’t covered. Add a test that triggers toggleNode on a watched GitHub repo node, verifies the correct contents API URL is requested, and asserts children are filtered to directories + isMissionFile matches (and that non-mission files are excluded).

clubanderson · 2026-04-01T02:14:22Z

🔄 Auto-Applying Copilot Code Review

Copilot code review found 2 code suggestion(s) and 1 general comment(s).

@copilot Please apply all of the following code review suggestions:

web/src/components/missions/MissionBrowser.tsx (line 614): const pathParts = node.path.split('/') const [owner, repo, ...subPat...
web/src/components/missions/MissionBrowser.tsx (line 599): '/api/github/user/repos?hasMissionsDir=true'

Also address these general comments:

web/src/components/missions/MissionBrowser.tsx (line 626): MissionBrowser has unit tests, but the new GitHub tree expansion behavior isn’t covered. Add a test that triggers `toggl

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.

Auto-generated by copilot-review-apply workflow.

Copilot AI review requested due to automatic review settings April 1, 2026 02:08

clubanderson merged commit 41e64df into main Apr 1, 2026

kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 1, 2026

kubestellar-prow bot deleted the fix/github-repo-tree-contents branch April 1, 2026 02:08

kubestellar-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 1, 2026

Copilot started reviewing on behalf of clubanderson April 1, 2026 02:09 View session

Copilot AI reviewed Apr 1, 2026

View reviewed changes

clubanderson assigned Copilot Apr 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Fix GitHub repo tree to show file contents instead of empty#4063

🐛 Fix GitHub repo tree to show file contents instead of empty#4063
clubanderson merged 1 commit intomainfrom
fix/github-repo-tree-contents

clubanderson commented Apr 1, 2026

Uh oh!

kubestellar-prow bot commented Apr 1, 2026

Uh oh!

netlify bot commented Apr 1, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

clubanderson commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-            const repoPath = node.path
-            const { data: ghEntries } = await api.get<Array<{ name: string; path: string; type: string; size?: number }>>(
-              `/api/github/repos/${repoPath}/contents`
+            const pathParts = node.path.split('/')
+            const [owner, repo, ...subPathParts] = pathParts
+            const subPath = subPathParts.join('/')
+            const repoPath = `${owner}/${repo}`
+            const contentsUrl = subPath
+              ? `/api/github/repos/${owner}/${repo}/contents/${subPath}`
+              : `/api/github/repos/${owner}/${repo}/contents/`
+            const { data: ghEntries } = await api.get<Array<{ name: string; path: string; type: string; size?: number }>>(
+              contentsUrl

	'/api/github/repos?hasMissionsDir=true'
	'/api/github/user/repos?hasMissionsDir=true'

Conversation

clubanderson commented Apr 1, 2026

Summary

Test plan

Uh oh!

kubestellar-prow bot commented Apr 1, 2026

Uh oh!

netlify bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

clubanderson commented Apr 1, 2026

🔄 Auto-Applying Copilot Code Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Apr 1, 2026 •

edited

Loading