Skip to content

πŸ› Fix unreadable green line β€” make dev mode indicator legible#4095

Merged
clubanderson merged 2 commits intomainfrom
fix/green-line-dev-indicator
Apr 1, 2026
Merged

πŸ› Fix unreadable green line β€” make dev mode indicator legible#4095
clubanderson merged 2 commits intomainfrom
fix/green-line-dev-indicator

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

Summary

The dev mode indicator bar at the top of the viewport was 5px tall with 6px unreadable text, causing users to report it as a CSS bug (#4080).

Now 20px tall with legible 10px "Development Mode" text on a green background β€” clearly intentional, like VS Code's debug mode bar.

Only visible in development mode (npm run dev / startup-oauth.sh). Production builds are unaffected.

Fixes #4080

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
The dev mode bar was 5px tall with 6px text, making it look like a
CSS bug rather than a purposeful indicator. Now 20px tall with 10px
legible "Development Mode" text on a green background.

Fixes #4080

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings April 1, 2026 11:18
@clubanderson clubanderson merged commit b50dc70 into main Apr 1, 2026
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 1, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

πŸ‘‹ Hey @clubanderson β€” thanks for opening this PR!

πŸ€– This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@kubestellar-prow kubestellar-prow bot deleted the fix/green-line-dev-indicator branch April 1, 2026 11:18
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

βœ… Deploy Preview for kubestellarconsole ready!

Name Link
πŸ”¨ Latest commit 2e40794
πŸ” Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69ccff0dee96080008b6456b
😎 Deploy Preview https://deploy-preview-4095.console-deploy-preview.kubestellar.io
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow kubestellar-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the development-only UI indicator at the top of the layout to avoid looking like an unintended CSS artifact, addressing issue #4080. Also includes a README badge change.

Changes:

  • Replaced the tiny dev-mode β€œaccent line” with a taller bar and readable β€œDevelopment Mode” label in Layout.
  • Removed the OpenSSF Scorecard badge from README.md.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
web/src/components/layout/Layout.tsx Adjusts the dev-mode indicator styling/content intended to clarify the green line is intentional.
README.md Removes an OpenSSF Scorecard badge link.

{Array.from({ length: 6 }, (_, i) => (
<span key={i} className="text-[6px] font-extrabold uppercase tracking-widest text-green-300 leading-none bg-green-950/60 px-1 py-px rounded-sm">dev mode</span>
))}
<div className="h-5 bg-green-600 flex-shrink-0 z-[60] flex items-center justify-center gap-4">
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dev-mode indicator bar is rendered as a normal-flow element, but the Navbar is fixed top-0 ... z-50 (web/src/components/layout/navbar/Navbar.tsx:50). This means the indicator will sit underneath the navbar (and z-[60] won’t apply because the element isn’t positioned), so the text may still be obscured and the green bar may continue to look like a translucent artifact through the navbar. Consider making the indicator positioned (fixed/sticky/relative) and adjusting the navbar top offset + NAVBAR_HEIGHT/banner offsets accordingly so the bar is truly visible and doesn’t steal layout height behind the fixed navbar.

Suggested change
<div className="h-5 bg-green-600 flex-shrink-0 z-[60] flex items-center justify-center gap-4">
<div className="fixed top-0 inset-x-0 h-5 bg-green-600 z-[60] flex items-center justify-center gap-4">

Copilot uses AI. Check for mistakes.
Comment on lines 1 to 5
# KubeStellar Console

![Coverage](https://img.shields.io/endpoint?url=https://gist.githubusercontent.com/clubanderson/b9a9ae8469f1897a22d5a40629bc1e82/raw/coverage-badge.json)
[![OpenSSF Scorecard](https://api.scorecard.dev/projects/github.com/kubestellar/console/badge)](https://scorecard.dev/viewer/?uri=github.com/kubestellar/console)
[![OpenSSF Best Practices](https://www.bestpractices.dev/projects/12343/badge)](https://www.bestpractices.dev/projects/12343)

Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is described as a dev-mode UI legibility fix, but this change removes the OpenSSF Scorecard badge from the README without explanation in the PR description. If this is intentional (e.g., badge endpoint deprecated), please mention it in the PR summary; otherwise, consider reverting to keep the PR scoped to #4080.

Copilot uses AI. Check for mistakes.
@clubanderson
Copy link
Copy Markdown
Collaborator Author

πŸ”„ Auto-Applying Copilot Code Review

Copilot code review found 1 code suggestion(s) and 1 general comment(s).

@copilot Please apply all of the following code review suggestions:

  • web/src/components/layout/Layout.tsx (line 297): <div className="fixed top-0 inset-x-0 h-5 bg-green-600 z-[60] flex items-center ...

Also address these general comments:

  • README.md (line 5): This PR is described as a dev-mode UI legibility fix, but this change removes the OpenSSF Scorecard badge from the READM

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.


Auto-generated by copilot-review-apply workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: unintended green line appears across top of page due to layout/CSS issue

3 participants