🐛 Don't cancel coverage-gate runs on push to main#4102
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
There was a problem hiding this comment.
Pull request overview
Adjusts the GitHub Actions concurrency configuration for the coverage gate workflow so that push-to-main coverage runs are no longer cancelled by subsequent merges, allowing the coverage badge update to complete reliably.
Changes:
- Makes
cancel-in-progressconditional so only PR-triggered runs cancel stale in-flight runs. - Uses a PR-number-or-SHA concurrency group key to avoid collisions between PR runs and push runs.
|
|
||
| concurrency: | ||
| # PRs: cancel stale runs for same PR. Push to main: unique group per SHA so runs never cancel each other. | ||
| group: coverage-gate-${{ github.event.pull_request.number || github.sha }} |
There was a problem hiding this comment.
Because on: includes workflow_dispatch, group: coverage-gate-${{ github.event.pull_request.number || github.sha }} can put a manual dispatch run and a push-to-main run for the same commit SHA into the same concurrency group. That will serialize those runs (push will queue behind dispatch), which can delay the coverage badge update. Consider including github.event_name (and/or github.ref) in the group key so push runs don’t get blocked by workflow_dispatch runs while still keeping PR cancellation behavior.
| group: coverage-gate-${{ github.event.pull_request.number || github.sha }} | |
| group: coverage-gate-${{ github.event_name }}-${{ github.event.pull_request.number || github.sha }} |
🔄 Auto-Applying Copilot Code ReviewCopilot code review found 1 code suggestion(s) and 0 general comment(s). @copilot Please apply all of the following code review suggestions:
Push all fixes in a single commit. Run Auto-generated by copilot-review-apply workflow. |
Push-to-main coverage runs kept getting cancelled by subsequent merges. Now only PR runs cancel each other — push runs complete independently so the badge actually updates.