Skip to content

🐛 Don't cancel coverage-gate runs on push to main#4102

Merged
clubanderson merged 1 commit intomainfrom
fix/coverage-no-cancel-main
Apr 1, 2026
Merged

🐛 Don't cancel coverage-gate runs on push to main#4102
clubanderson merged 1 commit intomainfrom
fix/coverage-no-cancel-main

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

Push-to-main coverage runs kept getting cancelled by subsequent merges. Now only PR runs cancel each other — push runs complete independently so the badge actually updates.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings April 1, 2026 11:49
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 1, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 03b9dac
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69cd0658b296af0008974ee1
😎 Deploy Preview https://deploy-preview-4102.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@kubestellar-prow kubestellar-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2026
@clubanderson clubanderson merged commit 15d5284 into main Apr 1, 2026
15 of 17 checks passed
@kubestellar-prow kubestellar-prow bot deleted the fix/coverage-no-cancel-main branch April 1, 2026 11:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the GitHub Actions concurrency configuration for the coverage gate workflow so that push-to-main coverage runs are no longer cancelled by subsequent merges, allowing the coverage badge update to complete reliably.

Changes:

  • Makes cancel-in-progress conditional so only PR-triggered runs cancel stale in-flight runs.
  • Uses a PR-number-or-SHA concurrency group key to avoid collisions between PR runs and push runs.


concurrency:
# PRs: cancel stale runs for same PR. Push to main: unique group per SHA so runs never cancel each other.
group: coverage-gate-${{ github.event.pull_request.number || github.sha }}
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because on: includes workflow_dispatch, group: coverage-gate-${{ github.event.pull_request.number || github.sha }} can put a manual dispatch run and a push-to-main run for the same commit SHA into the same concurrency group. That will serialize those runs (push will queue behind dispatch), which can delay the coverage badge update. Consider including github.event_name (and/or github.ref) in the group key so push runs don’t get blocked by workflow_dispatch runs while still keeping PR cancellation behavior.

Suggested change
group: coverage-gate-${{ github.event.pull_request.number || github.sha }}
group: coverage-gate-${{ github.event_name }}-${{ github.event.pull_request.number || github.sha }}

Copilot uses AI. Check for mistakes.
@clubanderson
Copy link
Copy Markdown
Collaborator Author

🔄 Auto-Applying Copilot Code Review

Copilot code review found 1 code suggestion(s) and 0 general comment(s).

@copilot Please apply all of the following code review suggestions:

  • .github/workflows/coverage-gate.yml (line 24): group: coverage-gate-${{ github.event_name }}-${{ github.event.pull_request.numb...

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.


Auto-generated by copilot-review-apply workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants