Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the hourly coverage GitHub Actions workflow to prevent out-of-memory failures during coverage-instrumented test runs by increasing Node.js heap size.
Changes:
- Set
NODE_OPTIONSto raise--max-old-space-sizefrom the default to 8192 MB for the coverage run step.
| env: | ||
| NODE_OPTIONS: '--max-old-space-size=8192' |
There was a problem hiding this comment.
Hard-coding an 8GB heap can exceed what the GitHub-hosted runner can reliably allocate depending on runner type and concurrent process memory, potentially turning an OOM into a slower/failing job for different reasons. Consider using a smaller bump (e.g., 6144) or making the heap size configurable via a workflow/env variable so it can be tuned without code changes (and optionally documenting the expected runner size).
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
🔄 Auto-Applying Copilot Code ReviewCopilot code review found 0 code suggestion(s) and 1 general comment(s). Also address these general comments:
Push all fixes in a single commit. Run Auto-generated by copilot-review-apply workflow. |
Test suite OOMs at 4GB with coverage instrumentation. Increase to 8GB.