Skip to content

🐛 Fix OOM in hourly coverage suite#4166

Merged
clubanderson merged 1 commit intomainfrom
fix/coverage-oom
Apr 1, 2026
Merged

🐛 Fix OOM in hourly coverage suite#4166
clubanderson merged 1 commit intomainfrom
fix/coverage-oom

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

Test suite OOMs at 4GB with coverage instrumentation. Increase to 8GB.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings April 1, 2026 14:19
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 1, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2026
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 7060cb6
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69cd295960ba260008bfa413
😎 Deploy Preview https://deploy-preview-4166.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@clubanderson clubanderson merged commit 5436769 into main Apr 1, 2026
14 of 16 checks passed
@kubestellar-prow kubestellar-prow bot deleted the fix/coverage-oom branch April 1, 2026 14:19
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the hourly coverage GitHub Actions workflow to prevent out-of-memory failures during coverage-instrumented test runs by increasing Node.js heap size.

Changes:

  • Set NODE_OPTIONS to raise --max-old-space-size from the default to 8192 MB for the coverage run step.

Comment on lines +41 to +42
env:
NODE_OPTIONS: '--max-old-space-size=8192'
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coding an 8GB heap can exceed what the GitHub-hosted runner can reliably allocate depending on runner type and concurrent process memory, potentially turning an OOM into a slower/failing job for different reasons. Consider using a smaller bump (e.g., 6144) or making the heap size configurable via a workflow/env variable so it can be tuned without code changes (and optionally documenting the expected runner size).

Copilot uses AI. Check for mistakes.
@clubanderson clubanderson restored the fix/coverage-oom branch April 1, 2026 14:40
@kubestellar-prow kubestellar-prow bot deleted the fix/coverage-oom branch April 1, 2026 14:41
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@clubanderson
Copy link
Copy Markdown
Collaborator Author

🔄 Auto-Applying Copilot Code Review

Copilot code review found 0 code suggestion(s) and 1 general comment(s).

Also address these general comments:

  • .github/workflows/coverage-hourly.yml (line 42): Hard-coding an 8GB heap can exceed what the GitHub-hosted runner can reliably allocate depending on runner type and conc

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.


Auto-generated by copilot-review-apply workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants