🐛 Fix Auto-QA issues: button patterns and missing test coverage by clubanderson · Pull Request #4172 · kubestellar/console

clubanderson · 2026-04-01T14:38:32Z

Summary

[Auto-QA] Inconsistent component patterns detected #4164 (Inconsistent patterns): Replaced raw <button> elements in Tour.tsx (4 buttons) and Onboarding.tsx (4 buttons) with the shared Button component for consistent styling and behavior
[Auto-QA] Components missing test coverage #4168 (Missing test coverage): Added smoke tests for 12 untested components: Tour, Onboarding, CardHistory, HelmReleases, Deployments, RewardsPanel, GitHubInvite, LinkedInShare, CommandLineTab, ImportTab, PodExecTerminal, SlackNotificationSettings
[Auto-QA] ROADMAP.md governance issues #4162 (ROADMAP.md): False positive — the ROADMAP.md already contains all required sections (Near-Term, Mid-Term, Long-Term, Non-Goals). Will close with comment.

Test plan

npx tsc --noEmit passes
All 14 new tests pass (npx vitest run)
CI build/lint pass

Closes #4164
Closes #4168

Replace raw <button> elements in Tour.tsx and Onboarding.tsx with the shared Button component for consistent styling (#4164). Add smoke tests for 12 untested components: Tour, Onboarding, CardHistory, HelmReleases, Deployments, RewardsPanel, GitHubInvite, LinkedInShare, CommandLineTab, ImportTab, PodExecTerminal, SlackNotificationSettings (#4168). Closes #4164 Closes #4168 Signed-off-by: Andrew Anderson <andy@clubanderson.com>

netlify · 2026-04-01T14:38:40Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`b4e418b`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/69cd2dedee960800087bec5e
😎 Deploy Preview	https://deploy-preview-4172.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

kubestellar-prow · 2026-04-01T14:38:40Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copilot

Pull request overview

This PR addresses Auto-QA findings by standardizing button usage in onboarding UI and adding basic smoke tests to cover previously untested components.

Changes:

Replaced several raw <button> elements with the shared Button component in onboarding-related UI for consistent styling/behavior.
Added Vitest smoke tests for multiple UI components to close gaps in component-level test coverage.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
web/src/components/terminal/tests/PodExecTerminal.test.tsx	Adds a non-rendering smoke test validating the PodExecTerminal export with xterm mocked.
web/src/components/settings/sections/tests/SlackNotificationSettings.test.tsx	Adds a render smoke test for Slack notification settings with supporting mocks.
web/src/components/rewards/tests/RewardsPanel.test.tsx	Adds an import-based smoke test for RewardsPanel with hooks mocked.
web/src/components/rewards/tests/LinkedInShare.test.tsx	Adds render smoke tests for LinkedIn share button/card with hooks mocked.
web/src/components/rewards/tests/GitHubInvite.test.tsx	Adds a render smoke test for the GitHub invite button with hooks mocked.
web/src/components/onboarding/tests/Tour.test.tsx	Adds render smoke tests for Tour components with tour hook mocked.
web/src/components/onboarding/tests/Onboarding.test.tsx	Adds an import-based smoke test for the Onboarding export with routing/auth mocked.
web/src/components/onboarding/Tour.tsx	Replaces raw buttons with the shared `Button` component in tour overlay/trigger UI.
web/src/components/onboarding/Onboarding.tsx	Replaces raw buttons with the shared `Button` component in onboarding navigation/ranking UI.
web/src/components/history/tests/CardHistory.test.tsx	Adds a render smoke test for CardHistory with history hook mocked.
web/src/components/helm/tests/HelmReleases.test.tsx	Adds an import-based smoke test for HelmReleases with dashboard hooks mocked.
web/src/components/deployments/tests/Deployments.test.tsx	Adds an import-based smoke test for Deployments with cached-data hooks mocked.
web/src/components/clusters/add-cluster/tests/ImportTab.test.tsx	Adds a render smoke test for ImportTab.
web/src/components/clusters/add-cluster/tests/CommandLineTab.test.tsx	Adds a render smoke test for CommandLineTab.

Copilot · 2026-04-01T14:46:40Z

web/src/components/onboarding/Tour.tsx

-      )}
+      icon={<LogoWithStar className="w-5 h-5" />}
+      className={cn(!hasCompletedTour && 'animate-pulse')}
      title="Take a tour"


When hasCompletedTour is true, this button becomes icon-only (no visible text). title is not a reliable accessible name for screen readers. Add an aria-label (or include a visually-hidden text node) so the trigger remains accessible in the completed state.

Suggested change

title="Take a tour"

title="Take a tour"

aria-label="Take the tour"

Copilot · 2026-04-01T14:46:40Z

web/src/components/rewards/__tests__/RewardsPanel.test.tsx

+vi.mock('../../../lib/demoMode', () => ({
+  isDemoMode: () => true, getDemoMode: () => true, isNetlifyDeployment: false,
+  isDemoModeForced: false, canToggleDemoMode: () => true, setDemoMode: vi.fn(),
+  toggleDemoMode: vi.fn(), subscribeDemoMode: () => () => {},
+  isDemoToken: () => true, hasRealToken: () => false, setDemoToken: vi.fn(),
+  isFeatureEnabled: () => true,
+}))
+
+vi.mock('../../../hooks/useDemoMode', () => ({
+  getDemoMode: () => true, default: () => true,
+  useDemoMode: () => ({ isDemoMode: true, toggleDemoMode: vi.fn(), setDemoMode: vi.fn() }),
+  hasRealToken: () => false, isDemoModeForced: false, isNetlifyDeployment: false,
+  canToggleDemoMode: () => true, isDemoToken: () => true, setDemoToken: vi.fn(),
+  setGlobalDemoMode: vi.fn(),
+}))
+
+vi.mock('../../../lib/analytics', () => ({
+  emitNavigate: vi.fn(), emitLogin: vi.fn(), emitEvent: vi.fn(), analyticsReady: Promise.resolve(),
+  emitAddCardModalOpened: vi.fn(), emitCardExpanded: vi.fn(), emitCardRefreshed: vi.fn(),
+  emitLinkedInShare: vi.fn(),
+}))
+
+vi.mock('../../../hooks/useTokenUsage', () => ({
+  useTokenUsage: () => ({ usage: { total: 0, remaining: 0, used: 0 }, isLoading: false }),
+  tokenUsageTracker: { getUsage: () => ({ total: 0, remaining: 0, used: 0 }), trackRequest: vi.fn(), getSettings: () => ({ enabled: false }) },
+}))


This same mock setup (demo mode, analytics, token usage, i18n) is duplicated across many new smoke tests. To reduce upkeep and avoid widespread breakage when any of these modules change, consider extracting these into a shared test helper or a common Vitest setup file and reusing them across the test suite.

Copilot · 2026-04-01T14:46:41Z

web/src/components/rewards/__tests__/GitHubInvite.test.tsx

+describe('GitHubInviteButton', () => {
+  it('renders without crashing', () => {
+    const { container } = render(<GitHubInviteButton onClick={vi.fn()} />)
+    expect(container).toBeTruthy()


expect(container).toBeTruthy() is effectively a no-op because container will always be truthy if render() returns. If the intent is a smoke test, consider asserting something observable (e.g., getByRole('button')), or at least expect(container.firstChild).not.toBeNull() to ensure something actually rendered.

Suggested change

expect(container).toBeTruthy()

expect(container.firstChild).not.toBeNull()

github-actions · 2026-04-01T14:58:51Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

github-actions · 2026-04-01T14:58:55Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

clubanderson · 2026-04-01T14:59:09Z

🔄 Auto-Applying Copilot Code Review

Copilot code review found 2 code suggestion(s) and 1 general comment(s).

@copilot Please apply all of the following code review suggestions:

web/src/components/onboarding/Tour.tsx (line 459): title="Take a tour" aria-label="Take the tour"
web/src/components/rewards/__tests__/GitHubInvite.test.tsx (line 55): expect(container.firstChild).not.toBeNull()

Also address these general comments:

web/src/components/rewards/__tests__/RewardsPanel.test.tsx (line 31): This same mock setup (demo mode, analytics, token usage, i18n) is duplicated across many new smoke tests. To reduce upke

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.

Auto-generated by copilot-review-apply workflow.

- Tour.tsx: Add aria-label on icon-only tour button (#4172) - ConsoleOfflineDetectionCard: Hoist GPU_CLUSTER_EXHAUSTION_THRESHOLD to module scope, fix comments "80%+" → ">80%" (#4185) - coverage-hourly.yml: Replace always() with success check to avoid noisy merge-coverage failures when shards fail (#4185) Signed-off-by: Andrew Anderson <andy@clubanderson.com>

…ow (#4186) - Tour.tsx: Add aria-label on icon-only tour button (#4172) - ConsoleOfflineDetectionCard: Hoist GPU_CLUSTER_EXHAUSTION_THRESHOLD to module scope, fix comments "80%+" → ">80%" (#4185) - coverage-hourly.yml: Replace always() with success check to avoid noisy merge-coverage failures when shards fail (#4185) Signed-off-by: Andrew Anderson <andy@clubanderson.com>

) * 🐛 Address Copilot comments: tour a11y, GPU threshold, coverage workflow - Tour.tsx: Add aria-label on icon-only tour button (#4172) - ConsoleOfflineDetectionCard: Hoist GPU_CLUSTER_EXHAUSTION_THRESHOLD to module scope, fix comments "80%+" → ">80%" (#4185) - coverage-hourly.yml: Replace always() with success check to avoid noisy merge-coverage failures when shards fail (#4185) Signed-off-by: Andrew Anderson <andy@clubanderson.com> * 🌱 Add debug logging for screenshot upload flow in feedback dialog All logs use console.debug with [Screenshot] prefix for easy filtering in browser DevTools. Logs at each stage: - File selection (drag, drop, paste, file picker): file count, types, sizes - FileReader: loaded data URI length, errors - Paste: clipboard item types, getAsFile results - Submit: screenshot count, sizes, timeout, success/failure details This helps team members diagnose why screenshot uploads fail on their machines while working on the reporter's machine. Signed-off-by: Andrew Anderson <andy@clubanderson.com> --------- Signed-off-by: Andrew Anderson <andy@clubanderson.com>

Copilot AI review requested due to automatic review settings April 1, 2026 14:38

kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 1, 2026

clubanderson merged commit c670702 into main Apr 1, 2026
7 checks passed

kubestellar-prow bot deleted the fix/auto-qa-final branch April 1, 2026 14:38

kubestellar-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 1, 2026

This was referenced Apr 1, 2026

[Auto-QA] Inconsistent component patterns detected #4164

Closed

[Auto-QA] Components missing test coverage #4168

Closed

Copilot AI reviewed Apr 1, 2026

View reviewed changes

clubanderson assigned Copilot Apr 1, 2026

Copilot started reviewing on behalf of clubanderson April 1, 2026 15:00 View session

clubanderson mentioned this pull request Apr 1, 2026

🐛 Address Copilot comments: tour a11y, GPU threshold scope, coverage workflow #4186

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Fix Auto-QA issues: button patterns and missing test coverage#4172

🐛 Fix Auto-QA issues: button patterns and missing test coverage#4172
clubanderson merged 1 commit intomainfrom
fix/auto-qa-final

clubanderson commented Apr 1, 2026

Uh oh!

Uh oh!

netlify bot commented Apr 1, 2026 •

edited

Loading

Uh oh!

kubestellar-prow bot commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

Copilot AI Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

clubanderson commented Apr 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	title="Take a tour"
	title="Take a tour"
	aria-label="Take the tour"

	expect(container).toBeTruthy()
	expect(container.firstChild).not.toBeNull()

Conversation

clubanderson commented Apr 1, 2026

Summary

Test plan

Uh oh!

Uh oh!

netlify bot commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

kubestellar-prow bot commented Apr 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 1, 2026

Uh oh!

clubanderson commented Apr 1, 2026

🔄 Auto-Applying Copilot Code Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Apr 1, 2026 •

edited

Loading