Skip to content

🐛 Fix coverage: every 2 hours, never cancel#4178

Merged
clubanderson merged 1 commit intomainfrom
fix/coverage-no-cancel
Apr 1, 2026
Merged

🐛 Fix coverage: every 2 hours, never cancel#4178
clubanderson merged 1 commit intomainfrom
fix/coverage-no-cancel

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

Hourly cron cancelled the previous run at 25 min (just before completion). Changed to every 2 hours with cancel-in-progress: false.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings April 1, 2026 15:46
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 1, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit f2170bd
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69cd3dbb0c10970008cee47e

@kubestellar-prow kubestellar-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2026
@clubanderson clubanderson merged commit e2c1506 into main Apr 1, 2026
14 of 15 checks passed
@kubestellar-prow kubestellar-prow bot deleted the fix/coverage-no-cancel branch April 1, 2026 15:46
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the scheduled coverage GitHub Actions workflow to avoid runs being cancelled shortly before completion by reducing cadence and disabling cancellation for in-progress runs.

Changes:

  • Change cron schedule from hourly to every 2 hours at :15.
  • Set workflow concurrency to not cancel in-progress runs.

on:
schedule:
- cron: '15 * * * *' # Every hour at :15
- cron: '15 */2 * * *' # Every 2 hours at :15 (run takes ~25 min)
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow name/comment still say "Hourly" / "every hour", but the schedule is now every 2 hours. Updating the workflow name and header comments would keep the Actions UI and inline docs consistent with the new cadence.

Copilot uses AI. Check for mistakes.
concurrency:
group: coverage-hourly
cancel-in-progress: true
cancel-in-progress: false # Never cancel — let runs complete
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With cancel-in-progress now false, the concurrency group label "coverage-hourly" (and related identifiers like artifact naming) is slightly misleading given the new 2-hour cadence. Consider renaming the concurrency group (and any related identifiers) to reflect the updated schedule to reduce confusion when triaging runs.

Copilot uses AI. Check for mistakes.
@clubanderson
Copy link
Copy Markdown
Collaborator Author

🔄 Auto-Applying Copilot Code Review

Copilot code review found 0 code suggestion(s) and 2 general comment(s).

Also address these general comments:

  • .github/workflows/coverage-hourly.yml (line 8): The workflow name/comment still say "Hourly" / "every hour", but the schedule is now every 2 hours. Updating the workflo
  • .github/workflows/coverage-hourly.yml (line 13): With cancel-in-progress now false, the concurrency group label "coverage-hourly" (and related identifiers like artifact

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.


Auto-generated by copilot-review-apply workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants