🐛 Fix coverage: every 2 hours, never cancel#4178
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole canceled.
|
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
There was a problem hiding this comment.
Pull request overview
Updates the scheduled coverage GitHub Actions workflow to avoid runs being cancelled shortly before completion by reducing cadence and disabling cancellation for in-progress runs.
Changes:
- Change cron schedule from hourly to every 2 hours at :15.
- Set workflow concurrency to not cancel in-progress runs.
| on: | ||
| schedule: | ||
| - cron: '15 * * * *' # Every hour at :15 | ||
| - cron: '15 */2 * * *' # Every 2 hours at :15 (run takes ~25 min) |
There was a problem hiding this comment.
The workflow name/comment still say "Hourly" / "every hour", but the schedule is now every 2 hours. Updating the workflow name and header comments would keep the Actions UI and inline docs consistent with the new cadence.
| concurrency: | ||
| group: coverage-hourly | ||
| cancel-in-progress: true | ||
| cancel-in-progress: false # Never cancel — let runs complete |
There was a problem hiding this comment.
With cancel-in-progress now false, the concurrency group label "coverage-hourly" (and related identifiers like artifact naming) is slightly misleading given the new 2-hour cadence. Consider renaming the concurrency group (and any related identifiers) to reflect the updated schedule to reduce confusion when triaging runs.
🔄 Auto-Applying Copilot Code ReviewCopilot code review found 0 code suggestion(s) and 2 general comment(s). Also address these general comments:
Push all fixes in a single commit. Run Auto-generated by copilot-review-apply workflow. |
Hourly cron cancelled the previous run at 25 min (just before completion). Changed to every 2 hours with cancel-in-progress: false.