🐛 Throttle Complication Handler to 1 concurrent run#4180
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole canceled.
|
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
There was a problem hiding this comment.
Pull request overview
This PR throttles the “Complication Handler Workflow” GitHub Action to prevent multiple parallel runs triggered by frequent check_run completions, reducing runner contention.
Changes:
- Added a workflow-level
concurrencyconfiguration to serialize runs. - Updated the compiled workflow lock file to reflect the new concurrency group.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/handle-complications.md | Adds global concurrency settings to throttle the workflow to a single active run. |
| .github/workflows/handle-complications.lock.yml | Regenerates compiled workflow output with the updated concurrency group. |
|
|
||
| concurrency: | ||
| group: complication-handler-global | ||
| cancel-in-progress: true |
There was a problem hiding this comment.
With a global concurrency group, cancel-in-progress: true will cancel an in-flight run whenever a new event arrives (including events from different PRs). That can cause the handler to never finish processing some complications (e.g., PR1 run canceled by PR2 activity), leaving issues unhandled. Consider setting cancel-in-progress: false to queue runs instead, or scope the concurrency group to a PR/issue identifier so unrelated PRs don’t cancel each other.
| cancel-in-progress: true | |
| cancel-in-progress: false |
🔄 Auto-Applying Copilot Code ReviewCopilot code review found 1 code suggestion(s) and 0 general comment(s). @copilot Please apply all of the following code review suggestions:
Push all fixes in a single commit. Run Auto-generated by copilot-review-apply workflow. |
Was spawning 5+ parallel runs per PR merge (fires on every check_run completion). Global concurrency group ensures only 1 runs at a time, freeing runners for real CI jobs.