Skip to content

🐛 Throttle Complication Handler to 1 concurrent run#4180

Merged
clubanderson merged 1 commit intomainfrom
fix/complication-throttle
Apr 1, 2026
Merged

🐛 Throttle Complication Handler to 1 concurrent run#4180
clubanderson merged 1 commit intomainfrom
fix/complication-throttle

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

Was spawning 5+ parallel runs per PR merge (fires on every check_run completion). Global concurrency group ensures only 1 runs at a time, freeing runners for real CI jobs.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings April 1, 2026 16:03
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 1, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit c809638
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69cd41f02e930100082f1ac6

@kubestellar-prow kubestellar-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2026
@clubanderson clubanderson merged commit cc1a040 into main Apr 1, 2026
13 of 15 checks passed
@kubestellar-prow kubestellar-prow bot deleted the fix/complication-throttle branch April 1, 2026 16:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR throttles the “Complication Handler Workflow” GitHub Action to prevent multiple parallel runs triggered by frequent check_run completions, reducing runner contention.

Changes:

  • Added a workflow-level concurrency configuration to serialize runs.
  • Updated the compiled workflow lock file to reflect the new concurrency group.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/handle-complications.md Adds global concurrency settings to throttle the workflow to a single active run.
.github/workflows/handle-complications.lock.yml Regenerates compiled workflow output with the updated concurrency group.


concurrency:
group: complication-handler-global
cancel-in-progress: true
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a global concurrency group, cancel-in-progress: true will cancel an in-flight run whenever a new event arrives (including events from different PRs). That can cause the handler to never finish processing some complications (e.g., PR1 run canceled by PR2 activity), leaving issues unhandled. Consider setting cancel-in-progress: false to queue runs instead, or scope the concurrency group to a PR/issue identifier so unrelated PRs don’t cancel each other.

Suggested change
cancel-in-progress: true
cancel-in-progress: false

Copilot uses AI. Check for mistakes.
@clubanderson
Copy link
Copy Markdown
Collaborator Author

🔄 Auto-Applying Copilot Code Review

Copilot code review found 1 code suggestion(s) and 0 general comment(s).

@copilot Please apply all of the following code review suggestions:

  • .github/workflows/handle-complications.md (line 15): cancel-in-progress: false

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.


Auto-generated by copilot-review-apply workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants