Skip to content

🐛 Run coverage merge even if some shards fail#4183

Merged
clubanderson merged 1 commit intomainfrom
fix/coverage-merge-always
Apr 1, 2026
Merged

🐛 Run coverage merge even if some shards fail#4183
clubanderson merged 1 commit intomainfrom
fix/coverage-merge-always

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

Merge job was skipped because shard 3 got cancelled. Added always() so partial coverage still updates the badge.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings April 1, 2026 17:07
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 1, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 488e834
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69cd50c34511ef0007e0f60f

@kubestellar-prow kubestellar-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2026
@clubanderson clubanderson merged commit 058e57e into main Apr 1, 2026
14 checks passed
@kubestellar-prow kubestellar-prow bot deleted the fix/coverage-merge-always branch April 1, 2026 17:07
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Ensures the hourly coverage merge/badge update job still runs even when one or more test shards are cancelled or fail, so the repository’s coverage badge can be updated with partial results.

Changes:

  • Updates the merge-coverage job condition to use always() so it runs even if test-shard does not fully succeed.

merge-coverage:
needs: test-shard
if: github.repository == 'kubestellar/console'
if: always() && github.repository == 'kubestellar/console'
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With if: always(), this job can run even when the entire test-shard matrix ends up cancelled/produces no artifacts. In that case the merge step currently sets pct=0 and the gist-update step will publish a 0% badge, which is misleading (it looks like coverage dropped rather than “no data”). Consider emitting an output like has_shards=true/false (or leaving pct unset) and gating the badge update (and optionally the merged-artifact upload) so they only run when at least one shard coverage file was found.

Suggested change
if: always() && github.repository == 'kubestellar/console'
if: !cancelled() && github.repository == 'kubestellar/console'

Copilot uses AI. Check for mistakes.
@clubanderson
Copy link
Copy Markdown
Collaborator Author

🔄 Auto-Applying Copilot Code Review

Copilot code review found 1 code suggestion(s) and 0 general comment(s).

@copilot Please apply all of the following code review suggestions:

  • .github/workflows/coverage-hourly.yml (line 62): if: !cancelled() && github.repository == 'kubestellar/console'

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.


Auto-generated by copilot-review-apply workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants