🐛 Fix duplicate YAML keys in coverage workflow#4225
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
kubestellar-prow
bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole canceled.
|
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
kubestellar-prow
bot
added
the
size/XS
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
There was a problem hiding this comment.
Pull request overview
Fixes an invalid/ambiguous GitHub Actions workflow configuration caused by duplicate YAML keys introduced during a squash merge, ensuring the coverage workflow (including workflow_dispatch) uses a single, consistent shard configuration.
Changes:
- Removed duplicate
TOTAL_SHARDSenv key so only the intended value remains. - Removed duplicate
matrix.sharddefinition so the shard matrix is unambiguous (1–12).
| TOTAL_SHARDS: 10 | ||
|
|
||
| jobs: | ||
| # Run tests in 4 shards to stay within 7GB runner memory |
There was a problem hiding this comment.
The comment says tests run in 4 shards, but the matrix now runs 12 shards (and TOTAL_SHARDS=12). Update the comment to match the actual shard count to avoid confusion when adjusting CI resources/concurrency.
| # Run tests in 4 shards to stay within 7GB runner memory | |
| # Run tests in 12 shards to stay within 7GB runner memory |
🔄 Auto-Applying Copilot Code ReviewCopilot code review found 1 code suggestion(s) and 0 general comment(s). @copilot Please apply all of the following code review suggestions:
Push all fixes in a single commit. Run Auto-generated by copilot-review-apply workflow. |
Remove continue-on-error: true from test shard steps, which caused the test-shard job to always report success even when tests failed. The merge-coverage gate (needs.test-shard.result == 'success') was effectively a no-op. Copilot flagged this on 6 PRs (#4185, #4186, #4187, #4222, #4223, #4225). Changes: - Remove continue-on-error: true so shard failures are properly reported - Widen merge-coverage gate to !cancelled() so coverage is still merged from passing shards even when some fail - Add if-no-files-found: ignore on artifact upload so failed shards that produce no coverage file don't fail the upload step - Add final 'Fail if any shard failed' step so the overall workflow correctly surfaces test failures after merging coverage and updating the badge - Fix stale comment: '4 shards' -> '12 shards' Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Remove continue-on-error: true from test shard steps, which caused the test-shard job to always report success even when tests failed. The merge-coverage gate (needs.test-shard.result == 'success') was effectively a no-op. Copilot flagged this on 6 PRs (#4185, #4186, #4187, #4222, #4223, #4225). Changes: - Remove continue-on-error: true so shard failures are properly reported - Widen merge-coverage gate to !cancelled() so coverage is still merged from passing shards even when some fail - Add if-no-files-found: ignore on artifact upload so failed shards that produce no coverage file don't fail the upload step - Add final 'Fail if any shard failed' step so the overall workflow correctly surfaces test failures after merging coverage and updating the badge - Fix stale comment: '4 shards' -> '12 shards' Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Squash merge created duplicate TOTAL_SHARDS and shard keys. Fixes workflow_dispatch.