🐛 Fix false 'screenshot uploaded' message when upload fails by clubanderson · Pull Request #4226 · kubestellar/console

clubanderson · 2026-04-02T12:48:12Z

Summary

Backend: createGitHubIssueInRepo now returns screenshots_uploaded and screenshots_failed counts in the create response. When upload fails with 404, logs a hint that the GitHub token likely needs Contents: Read and write permission.
Frontend: Both FeatureRequestModal and FeedbackModal now use the backend response to display accurate screenshot status — green banner for success, yellow warning when uploads fail (with guidance to check token permissions). Previously, the UI always showed "Screenshot uploaded" based on local state regardless of backend result.

Root cause: The GitHub Contents API returns 404 when the token lacks Contents: Read and write permission (fine-grained PATs) or repo/public_repo scope (classic PATs). The Issues API works with just Issues: Read and write, so issue creation succeeds while screenshot upload silently fails.

Test plan

Submit feedback with a screenshot using a token that has Issues + Contents write permissions → green "Screenshot uploaded" banner
Submit feedback with a screenshot using a token that only has Issues write (no Contents) → yellow warning banner saying upload failed
Submit feedback without screenshots → no screenshot banner shown
Check backend logs for the helpful hint message when 404 occurs

…4220) The frontend always showed "Screenshot uploaded and attached to the issue" based on local state (screenshots.length > 0), regardless of whether the backend actually uploaded them to GitHub. When the GitHub token lacks Contents write permission, the upload silently fails with a 404 and the issue is created without screenshots — but the UI claims success. Backend: return screenshots_uploaded/screenshots_failed counts in the create response; add a hint log when 404 suggests missing token permission. Frontend: use the backend response to show accurate status — green for success, yellow warning when uploads fail with guidance to check token permissions. Signed-off-by: Andrew Anderson <andy@clubanderson.com>

kubestellar-prow · 2026-04-02T12:48:18Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-04-02T12:48:19Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`e8a3a81`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/69ce6591ec275000089d5bfe
😎 Deploy Preview	https://deploy-preview-4226.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-04-02T12:48:24Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

github-actions · 2026-04-02T12:48:28Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Copilot

Pull request overview

This PR addresses misleading UI feedback around screenshot attachments by propagating backend screenshot upload outcomes to the frontend, so the UI reflects what actually happened during GitHub issue creation.

Changes:

Backend: Track screenshot upload successes/failures during issue creation and return those counts in the create response.
Frontend: Use screenshots_uploaded / screenshots_failed from the create response to render success/warning screenshot status banners in both feedback submission modals.
Types: Extend the FeatureRequest interface to include optional screenshot upload count fields (present on create responses).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
web/src/hooks/useFeatureRequests.ts	Extends `FeatureRequest` typing with optional screenshot upload result counts.
web/src/components/feedback/FeedbackModal.tsx	Uses backend-provided counts to show accurate screenshot upload status banners after submit.
web/src/components/feedback/FeatureRequestModal.tsx	Uses backend-provided counts to show accurate screenshot upload status banners after submit.
pkg/api/handlers/feedback.go	Tracks screenshot upload results during issue creation and returns counts in the create response; logs a hint on likely permission-related 404s.

Copilot · 2026-04-02T12:53:26Z

pkg/api/handlers/feedback.go

+				if strings.Contains(err.Error(), "404") {
+					log.Printf("[Feedback] Hint: a 404 from the GitHub Contents API usually means the token lacks 'Contents: Read and write' permission. "+
+						"Ensure FEEDBACK_GITHUB_TOKEN has this scope for %s/%s.", repoOwner, repoName)


The 404 detection is currently based on strings.Contains(err.Error(), "404"), which is brittle (it can match unrelated messages) and ties behavior to string formatting. Prefer checking for a specific sentinel (e.g. prefix like "GitHub Contents API returned 404") or returning a typed error/status code from uploadScreenshotToGitHub.

Also, the hint mentions FEEDBACK_GITHUB_TOKEN, but getEffectiveToken() can source the token from runtime settings; consider wording this as “configured feedback GitHub token” to avoid misleading operators.

Suggested change

if strings.Contains(err.Error(), "404") {

log.Printf("[Feedback] Hint: a 404 from the GitHub Contents API usually means the token lacks 'Contents: Read and write' permission. "+

"Ensure FEEDBACK_GITHUB_TOKEN has this scope for %s/%s.", repoOwner, repoName)

if strings.HasPrefix(err.Error(), "GitHub Contents API returned 404") {

log.Printf("[Feedback] Hint: a 404 from the GitHub Contents API usually means the token lacks 'Contents: Read and write' permission. "+

"Ensure the configured feedback GitHub token has this scope for %s/%s.", repoOwner, repoName)

Copilot · 2026-04-02T12:53:27Z

pkg/api/handlers/feedback.go

+	// Return the request with screenshot upload status so the frontend can
+	// display an accurate message instead of always claiming success.
+	type createResponse struct {
+		*models.FeatureRequest
+		ScreenshotsUploaded int `json:"screenshots_uploaded"`
+		ScreenshotsFailed   int `json:"screenshots_failed"`
+	}
+	return c.Status(fiber.StatusCreated).JSON(createResponse{
+		FeatureRequest:      request,
+		ScreenshotsUploaded: ssResult.Uploaded,
+		ScreenshotsFailed:   ssResult.Failed,
+	})


CreateFeatureRequest now returns additional fields (screenshots_uploaded, screenshots_failed) via a new response wrapper. There are existing handler tests in pkg/api/handlers/feedback_test.go, but none appear to assert this response shape/behavior. Please add a unit test that exercises a successful create response and verifies these fields are present and correctly reflect upload outcomes (including partial failure).

Copilot · 2026-04-02T12:53:27Z

web/src/components/feedback/FeedbackModal.tsx

      console.debug('[Screenshot] Submit succeeded:', result.github_issue_url)
      if (hasScreenshots) emitScreenshotUploadSuccess(screenshotDataURIs.length)

      emitFeedbackSubmitted(type)

      // Award coins based on type
      const action = type === 'bug' ? 'bug_report' : 'feature_suggestion'
      awardCoins(action as 'bug_report' | 'feature_suggestion', { title, type })

      // Clear draft on successful submit
      localStorage.removeItem(DRAFT_KEY)
-      setSuccess({ issueUrl: result.github_issue_url })
+      setSuccess({
+        issueUrl: result.github_issue_url,
+        screenshotsUploaded: result.screenshots_uploaded,
+        screenshotsFailed: result.screenshots_failed,
+      })


emitScreenshotUploadSuccess(screenshotDataURIs.length) still fires on any successful request submission, even if the backend reports that 0 screenshots uploaded (or partial failures). Since you now have result.screenshots_uploaded / result.screenshots_failed, please base analytics on those counts (emit success only when uploaded > 0, and emit a failed event when failed > 0) so telemetry matches the actual upload result.

Copilot · 2026-04-02T12:53:27Z

web/src/components/feedback/FeedbackModal.tsx

+              {screenshots.length > 0 && success && (success.screenshotsFailed ?? 0) > 0 && (success.screenshotsUploaded ?? 0) === 0 && (
+                <div className="mb-4 p-3 rounded-lg bg-yellow-500/10 border border-yellow-500/20">
+                  <p className="text-xs text-yellow-400 font-medium">
+                    Screenshot could not be uploaded. The issue was created without it. Check that the GitHub token has &quot;Contents: Read and write&quot; permission.


The “all failed” warning message is always singular (“Screenshot could not be uploaded”) even when multiple screenshots were attached. Please pluralize based on screenshots.length (or success.screenshotsFailed) and consider aligning the guidance with the PR description (fine-grained PAT needs “Contents: Read and write”, classic PAT typically needs repo/public_repo) or use a more generally correct permission hint.

Suggested change

Screenshot could not be uploaded. The issue was created without it. Check that the GitHub token has "Contents: Read and write" permission.

{(success.screenshotsFailed ?? 0) === 1

? 'Screenshot could not be uploaded. The issue was created without it.'

: 'Screenshots could not be uploaded. The issue was created without them.'}{' '}

Check that the GitHub token has sufficient repository permissions (for example, fine-grained tokens usually need "Contents: Read and write"; classic tokens typically need "repo" or "public_repo" scope).

Copilot · 2026-04-02T12:53:27Z

web/src/components/feedback/FeatureRequestModal.tsx

+              {screenshots.length > 0 && success && (success.screenshotsFailed ?? 0) > 0 && (success.screenshotsUploaded ?? 0) === 0 && (
+                <div className="mt-4 p-3 rounded-lg bg-yellow-500/10 border border-yellow-500/20">
+                  <p className="text-xs text-yellow-400 font-medium">
+                    Screenshot could not be uploaded. The issue was created without it. Check that the GitHub token has &quot;Contents: Read and write&quot; permission.


The “all failed” warning message is always singular (“Screenshot could not be uploaded”) even when multiple screenshots were attached. Please pluralize based on screenshots.length / success.screenshotsFailed, and consider aligning the permission guidance with both fine-grained (“Contents: Read and write”) and classic PAT scopes (repo/public_repo) or wording it generically so it’s not misleading.

Suggested change

Screenshot could not be uploaded. The issue was created without it. Check that the GitHub token has "Contents: Read and write" permission.

{(success.screenshotsFailed ?? 0) === 1

? 'Screenshot could not be uploaded. The issue was created without it. Check that your GitHub token has permissions to read and write repository contents (for example, "Contents: Read and write" or classic scopes like "repo" / "public_repo").'

: 'Screenshots could not be uploaded. The issue was created without them. Check that your GitHub token has permissions to read and write repository contents (for example, "Contents: Read and write" or classic scopes like "repo" / "public_repo").'}

clubanderson · 2026-04-02T12:53:37Z

🔄 Auto-Applying Copilot Code Review

Copilot code review found 3 code suggestion(s) and 2 general comment(s).

@copilot Please apply all of the following code review suggestions:

pkg/api/handlers/feedback.go (line 1576): if strings.HasPrefix(err.Error(), "GitHub Contents API returned 404") { log...
web/src/components/feedback/FeedbackModal.tsx (line 386): {(success.screenshotsFailed ?? 0) === 1 ? 'Screenshot coul...
web/src/components/feedback/FeatureRequestModal.tsx (line 1260): {(success.screenshotsFailed ?? 0) === 1 ? 'Screenshot coul...

Also address these general comments:

pkg/api/handlers/feedback.go (line 195): CreateFeatureRequest now returns additional fields (screenshots_uploaded, screenshots_failed) via a new response w
web/src/components/feedback/FeedbackModal.tsx (line 228): emitScreenshotUploadSuccess(screenshotDataURIs.length) still fires on any successful request submission, even if the b

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.

Auto-generated by copilot-review-apply workflow.

kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 2, 2026

Copilot AI review requested due to automatic review settings April 2, 2026 12:48

clubanderson merged commit 42e1776 into main Apr 2, 2026
1 check passed

kubestellar-prow bot deleted the fix/screenshot-upload-status branch April 2, 2026 12:48

kubestellar-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 2, 2026

Copilot started reviewing on behalf of clubanderson April 2, 2026 12:49 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

clubanderson assigned Copilot Apr 2, 2026

clubanderson mentioned this pull request Apr 2, 2026

🐛 Actionable token permission guidance with GitHub + Settings links #4236

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Fix false 'screenshot uploaded' message when upload fails#4226

🐛 Fix false 'screenshot uploaded' message when upload fails#4226
clubanderson merged 1 commit intomainfrom
fix/screenshot-upload-status

clubanderson commented Apr 2, 2026

Uh oh!

kubestellar-prow bot commented Apr 2, 2026

Uh oh!

Uh oh!

netlify bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

clubanderson commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-                    Screenshot could not be uploaded. The issue was created without it. Check that the GitHub token has &quot;Contents: Read and write&quot; permission.
+                    {(success.screenshotsFailed ?? 0) === 1
+                      ? 'Screenshot could not be uploaded. The issue was created without it.'
+                      : 'Screenshots could not be uploaded. The issue was created without them.'}{' '}
+                    Check that the GitHub token has sufficient repository permissions (for example, fine-grained tokens usually need "Contents: Read and write"; classic tokens typically need "repo" or "public_repo" scope).

Conversation

clubanderson commented Apr 2, 2026

Summary

Test plan

Uh oh!

kubestellar-prow bot commented Apr 2, 2026

Uh oh!

Uh oh!

netlify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

clubanderson commented Apr 2, 2026

🔄 Auto-Applying Copilot Code Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Apr 2, 2026 •

edited

Loading