🐛 Fix drilldown z-index, RecordFocus validation, Kyverno docs link by clubanderson · Pull Request #4315 · kubestellar/console

clubanderson · 2026-04-02T19:18:24Z

Adding or modifying a card/dashboard? Read the Card Development Guide first — it covers required patterns, common pitfalls, and the full file checklist.

New CNCF project card? New cards go in kubestellar/console-marketplace, not this repo. PRs adding new cards here will be redirected.

Use a coding agent. This repo is primarily developed with Claude Code (Opus 4.5/4.6). It knows all codebase patterns (isDemoData, useCardLoadingState, locale strings, DCO). Manual PRs that miss required patterns will be sent back.

📝 Summary of Changes

Drilldown z-index (Triggering drillDowns in expanded view of cards causes the drillDown one layer below the card #4257): Set DrillDownModal z-index to z-[9999] to match the BaseModal layer, ensuring the drilldown modal renders above the expanded card overlay without introducing an escalating z-index value
RecordFocus validation (RecordFocus ignores JSON parse errors #4282): RecordFocus handler now checks the BodyParser error and returns HTTP 400 on malformed JSON, instead of silently proceeding with a zero-value summary
Kyverno docs link (Card: Kyverno Policies (kyverno_policies) #4267): Updated the Kyverno Policies card footer link from https://kyverno.io/docs/ (empty page) to https://kyverno.io/docs/introduction/

Changes Made

Updated DrillDownModal z-index to z-[9999] to align with the BaseModal layer and avoid z-index escalation
Added BodyParser error check in RecordFocus handler — returns HTTP 400 on malformed JSON
Updated Kyverno Policies card footer documentation URL to the introduction page
Added unit test TestRecordFocus_BadBody_Returns400 — posts malformed JSON to POST /api/cards/:id/focus and asserts HTTP 400 is returned

Checklist

Please ensure the following before submitting your PR:

I used a coding agent (Claude Code, Copilot, Gemini, or Codex) to generate/review this code
I have reviewed the project's contribution guidelines
New cards target console-marketplace, not this repo
isDemoData is wired correctly (cards show Demo badge when using demo data)
I have written unit tests for the changes (if applicable)
I have tested the changes locally and ensured they work as expected
All commits are signed with DCO (git commit -s)

Screenshots or Logs (if applicable)

N/A — no visual changes; z-index fix is a layering correction, link fix is a URL update, and RecordFocus fix is a server-side validation change.

👀 Reviewer Notes

The DrillDownModal z-index was revised from z-[10000] to z-[9999] per code review feedback to align with the existing BaseModal layer and avoid introducing an ever-escalating z-index value.
The TestRecordFocus_BadBody_Returns400 test uses a local recordFocusStore wrapper (embeds *test.MockStore and overrides GetCard/GetDashboard) so the handler reaches the BodyParser step in the test.

…4257, #4282, #4267) - Drilldown modal z-index raised to z-[10000] so it renders above the expanded card overlay (z-[9999]) instead of behind it - RecordFocus handler now checks BodyParser error and returns HTTP 400 on malformed JSON instead of silently proceeding with zero values - Kyverno Policies card documentation link updated from empty /docs/ page to /docs/introduction/ Signed-off-by: Andrew Anderson <andy@clubanderson.com>

netlify · 2026-04-02T19:18:30Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`9ced41b`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/69ced280c9e55a000804a625
😎 Deploy Preview	https://deploy-preview-4315.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-04-02T19:18:32Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

Copilot

Pull request overview

Fixes three user-facing issues across the console UI and API: drilldown modal layering in expanded card view, server-side validation for malformed RecordFocus payloads, and an updated Kyverno documentation link.

Changes:

Raised DrillDownModal z-index so it renders above the expanded card overlay.
Added BodyParser error handling in RecordFocus to return HTTP 400 for malformed JSON.
Updated Kyverno Policies card footer documentation link to a non-empty docs page.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
web/src/components/drilldown/DrillDownModal.tsx	Increases modal z-index to ensure drilldown overlays expanded-card modal layer.
web/src/components/cards/KyvernoPolicies.tsx	Updates footer “Documentation” URL to the Kyverno introduction page.
pkg/api/handlers/cards.go	Returns 400 on JSON parse errors in `RecordFocus` instead of proceeding with zero-value input.

Copilot · 2026-04-02T19:21:47Z

web/src/components/drilldown/DrillDownModal.tsx

  return (
    <div 
-      className="fixed inset-0 bg-black/60 backdrop-blur-2xl flex items-center justify-center z-50 p-2 md:p-4" 
+      className="fixed inset-0 bg-black/60 backdrop-blur-2xl flex items-center justify-center z-[10000] p-2 md:p-4"


z-[10000] introduces a new hard-coded z-index value that’s higher than the app’s standard modal layer (e.g., BaseModal uses z-[9999]). To avoid future “z-index arms races” and unintended layering over other overlays, consider centralizing modal z-indexes (Tailwind theme/utility or shared constant) or rendering this modal via the existing BaseModal/portal approach with a defined layer above expanded cards.

Suggested change

className="fixed inset-0 bg-black/60 backdrop-blur-2xl flex items-center justify-center z-[10000] p-2 md:p-4"

className="fixed inset-0 bg-black/60 backdrop-blur-2xl flex items-center justify-center z-[9999] p-2 md:p-4"

Copilot · 2026-04-02T19:21:48Z

pkg/api/handlers/cards.go

 	var input struct {
 		Summary string `json:"summary"`
 	}
-	c.BodyParser(&input)
+	if err := c.BodyParser(&input); err != nil {
+		return fiber.NewError(fiber.StatusBadRequest, "Invalid request body")
+	}


RecordFocus now returns 400 on BodyParser errors, but there’s no handler test covering this regression path. Add a unit test (similar to the existing CreateCard/UpdateCard bad-body tests) that posts malformed JSON to /api/cards/:id/focus, asserts HTTP 400, and asserts UpdateCardFocus is not called.

clubanderson · 2026-04-02T19:21:58Z

🔄 Auto-Applying Copilot Code Review

Copilot code review found 1 code suggestion(s) and 1 general comment(s).

@copilot Please apply all of the following code review suggestions:

web/src/components/drilldown/DrillDownModal.tsx (line 303): className="fixed inset-0 bg-black/60 backdrop-blur-2xl flex items-center justify...

Also address these general comments:

pkg/api/handlers/cards.go (line 204): RecordFocus now returns 400 on BodyParser errors, but there’s no handler test covering this regression path. Add a uni

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.

Auto-generated by copilot-review-apply workflow.

clubanderson · 2026-04-02T19:22:19Z

/lgtm
/approve

kubestellar-prow · 2026-04-02T19:22:22Z

@clubanderson: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubestellar-prow · 2026-04-02T19:22:26Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: clubanderson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [clubanderson]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

…Focus 400 test Signed-off-by: GitHub Copilot <copilot@github.com> Agent-Logs-Url: https://github.com/kubestellar/console/sessions/0f0857f6-2a6f-4a76-8b93-9bc67d0562db Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>

Copilot · 2026-04-02T20:35:34Z

🔄 Auto-Applying Copilot Code Review

Copilot code review found 1 code suggestion(s) and 1 general comment(s)....

Done in commit 9ced41b:

DrillDownModal z-index: Reverted from z-[10000] back to z-[9999] per the review suggestion — this aligns with the existing BaseModal layer rather than creating a higher arbitrary layer.
RecordFocus test: Added TestRecordFocus_BadBody_Returns400 in pkg/api/handlers/cards_test.go. The test uses a local recordFocusStore wrapper that overrides GetCard/GetDashboard to return a valid card and matching dashboard, so the handler reaches the BodyParser step. Posting {invalid json with Content-Type: application/json asserts HTTP 400 is returned.

github-actions · 2026-04-02T20:41:32Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 2, 2026

Copilot AI review requested due to automatic review settings April 2, 2026 19:18

kubestellar-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 2, 2026

Copilot started reviewing on behalf of clubanderson April 2, 2026 19:19 View session

Copilot AI reviewed Apr 2, 2026

View reviewed changes

clubanderson assigned Copilot Apr 2, 2026

kubestellar-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2026

Copilot started work on behalf of clubanderson April 2, 2026 20:21 View session

kubestellar-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 2, 2026

Copilot finished work on behalf of clubanderson April 2, 2026 20:36

clubanderson merged commit eb33460 into main Apr 2, 2026
25 of 26 checks passed

kubestellar-prow bot deleted the fix/small-ui-backend-fixes branch April 2, 2026 20:41

This was referenced Apr 2, 2026

RecordFocus ignores JSON parse errors #4282

Closed

Card: Kyverno Policies (kyverno_policies) #4267

Closed

Triggering drillDowns in expanded view of cards causes the drillDown one layer below the card #4257

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Fix drilldown z-index, RecordFocus validation, Kyverno docs link#4315

🐛 Fix drilldown z-index, RecordFocus validation, Kyverno docs link#4315
clubanderson merged 2 commits intomainfrom
fix/small-ui-backend-fixes

clubanderson commented Apr 2, 2026 •

edited by Copilot AI

Loading

Uh oh!

netlify bot commented Apr 2, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

Copilot AI Apr 2, 2026

Uh oh!

clubanderson commented Apr 2, 2026

Uh oh!

clubanderson commented Apr 2, 2026

Uh oh!

kubestellar-prow bot commented Apr 2, 2026

Uh oh!

kubestellar-prow bot commented Apr 2, 2026

Uh oh!

Copilot AI commented Apr 2, 2026

🔄 Auto-Applying Copilot Code Review

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	className="fixed inset-0 bg-black/60 backdrop-blur-2xl flex items-center justify-center z-[10000] p-2 md:p-4"
	className="fixed inset-0 bg-black/60 backdrop-blur-2xl flex items-center justify-center z-[9999] p-2 md:p-4"

Conversation

clubanderson commented Apr 2, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Summary of Changes

Changes Made

Checklist

Screenshots or Logs (if applicable)

👀 Reviewer Notes

Uh oh!

netlify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

clubanderson commented Apr 2, 2026

🔄 Auto-Applying Copilot Code Review

Uh oh!

clubanderson commented Apr 2, 2026

Uh oh!

kubestellar-prow bot commented Apr 2, 2026

Uh oh!

kubestellar-prow bot commented Apr 2, 2026

Uh oh!

Copilot AI commented Apr 2, 2026

🔄 Auto-Applying Copilot Code Review

Uh oh!

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

clubanderson commented Apr 2, 2026 •

edited by Copilot AI

Loading

netlify bot commented Apr 2, 2026 •

edited

Loading