🐛 Add MSW catch-all for unmocked API routes by clubanderson · Pull Request #4366 · kubestellar/console

clubanderson · 2026-04-03T01:51:22Z

Fix comment (// On Netlify, unhandled /api/* requests fall through to the SPA)
Add passthrough handlers for Netlify Function routes before the /api/* catch-all
- /api/nightly-e2e/*, /api/public/nightly-e2e/*
- /api/missions/*
- /api/analytics-dashboard
- /api/gtag, /api/m, /api/send, /api/ksc
Build and lint pass

- Add MSW handler for POST /auth/refresh — eliminates JSON parse errors from AuthCallback and silent token refresh getting HTML instead of JSON - Add www.googletagmanager.com to CSP connect-src — fixes GTM td endpoint being blocked by Content Security Policy - Add MSW passthrough for dicebear.com, fonts.gstatic.com, and fonts.googleapis.com — eliminates unhandled request warnings - Suppress MSW warnings for cross-origin requests and font files (.woff2/.woff/.ttf) in onUnhandledRequest handler Signed-off-by: Andrew Anderson <andy@clubanderson.com>

The unified-controls baseline (1 → 34) and non-localized strings baseline (167 → 187) drifted from reality as cards were added. Both counts are identical on main — this just syncs the baselines. Signed-off-by: Andrew Anderson <andy@clubanderson.com>

On Netlify, unhandled API requests fall through to the SPA catch-all which returns index.html (200 OK). Code calling .json() then throws "Unexpected token '<'". This catch-all returns 503 JSON so callers hit their error paths gracefully instead of parsing HTML as JSON. Fixes: /api/mcp/gpu-nodes/stream, /api/kagent/status, and any future unmocked API routes. Signed-off-by: Andrew Anderson <andy@clubanderson.com>

kubestellar-prow · 2026-04-03T01:51:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2026-04-03T01:51:28Z

✅ Deploy Preview for kubestellarconsole ready!

Name	Link
🔨 Latest commit	`79efe31`
🔍 Latest deploy log	https://app.netlify.com/projects/kubestellarconsole/deploys/69cf1d1eb657270007bbb6f7
😎 Deploy Preview	https://deploy-preview-4366.console-deploy-preview.kubestellar.io
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-04-03T01:51:32Z

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

Claude Code (Opus 4.5 / 4.6) — recommended

GitHub Copilot

Cursor

Other AI coding assistants

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

Copilot

Pull request overview

Adds a defensive MSW fallback response for otherwise-unhandled /api/* requests in Netlify/demo deployments, preventing HTML SPA fallback responses from being parsed as JSON and throwing Unexpected token '<'.

Changes:

Add additional MSW passthrough + mock handlers (external resources and /auth/refresh) and introduce an /api/* catch-all that returns JSON 503.
Update MSW onUnhandledRequest filtering to ignore more static asset types and suppress warnings for cross-origin requests.
Expand Netlify CSP connect-src to include https://www.googletagmanager.com.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
web/src/mocks/handlers.ts	Adds passthrough/mock handlers and a new `/api/*` catch-all JSON 503 response.
web/src/mocks/browser.ts	Tweaks MSW unhandled-request warning suppression for assets and cross-origin requests.
netlify.toml	Updates CSP to allow `googletagmanager.com` in `connect-src`.
.github/ai-non-localized-baseline.txt	Updates AI baseline count.
.github/ai-missing-unified-baseline.txt	Updates AI baseline count.

Copilot · 2026-04-03T01:54:36Z

web/src/mocks/handlers.ts

+  // ── Catch-all for unmocked API routes ────────────────────────────
+  // On Netlify, unhandled /api/* and /health requests fall through to the SPA
+  // catch-all which returns index.html (200 OK, text/html). Code calling
+  // .json() then throws "Unexpected token '<'". This catch-all returns a
+  // proper JSON 503 so callers hit their error paths gracefully.
+  http.all('/api/*', () => {
+    return HttpResponse.json(
+      { error: 'not available in demo mode' },
+      { status: 503 },
+    )
+  }),


The new http.all('/api/*') catch-all will intercept every same-origin /api/... request that isn't already mocked earlier in this file. That likely blocks Netlify Function-backed endpoints that should stay live in demo mode (e.g. /api/missions/*, /api/nightly-e2e/* + /api/public/nightly-e2e/*, /api/gtag, /api/m, /api/analytics-dashboard), turning them into 503s.

Suggested fix: add explicit allow-list passthrough handlers for the Netlify Function routes (placed before this catch-all), or narrow the catch-all scope to only the known non-existent backend prefixes (e.g. /api/mcp/*, /api/kagent/*, etc.).

Copilot · 2026-04-03T01:54:37Z

web/src/mocks/handlers.ts

  }),
+
+  // ── Catch-all for unmocked API routes ────────────────────────────
+  // On Netlify, unhandled /api/* and /health requests fall through to the SPA


The comment says unhandled "/api/* and /health" requests fall through, but this handler only matches /api/* (and /health is already explicitly mocked above). Please update the comment to match the actual behavior, or add a separate handler if /health is intended to be covered here.

Suggested change

// On Netlify, unhandled /api/* and /health requests fall through to the SPA

// On Netlify, unhandled /api/* requests fall through to the SPA

clubanderson · 2026-04-03T01:54:44Z

🔄 Auto-Applying Copilot Code Review

Copilot code review found 1 code suggestion(s) and 1 general comment(s).

@copilot Please apply all of the following code review suggestions:

web/src/mocks/handlers.ts (line 634): // On Netlify, unhandled /api/* requests fall through to the SPA

Also address these general comments:

web/src/mocks/handlers.ts (line 643): The new http.all('/api/*') catch-all will intercept every same-origin /api/... request that isn't already mocked e

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.

Auto-generated by copilot-review-apply workflow.

github-actions · 2026-04-03T02:01:53Z

Thank you for your contribution! Your PR has been merged.

Check out what's new:

KubeStellar Console — Live multi-cluster dashboard
Marketplace — Community extensions
Knowledge Base — Troubleshooting and how-tos

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

github-actions · 2026-04-03T02:05:14Z

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit 036783a83f05e28f29848e533c2f6c69c65f5150.

github-actions · 2026-04-03T02:12:06Z

✅ Post-Merge Verification: passed

Commit: 036783a83f05e28f29848e533c2f6c69c65f5150
Specs run: smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/23930484785

Copilot · 2026-04-03T02:13:04Z

🔄 Auto-Applying Copilot Code Review

Copilot code review found 1 code suggestion(s) and 1 general comment(s)....

Both review items addressed in commit d8760df:

Comment fix — updated to // On Netlify, unhandled /api/* requests fall through to the SPA (removed the incorrect /health mention)
Netlify Function allow-list passthrough — added explicit passthrough() handlers for all Netlify Function-backed routes before the /api/* catch-all:
- /api/nightly-e2e/*, /api/public/nightly-e2e/* → nightly-e2e.mts
- /api/missions/* → missions-file.mts, missions-browse.mts
- /api/analytics-dashboard → analytics-dashboard.mts
- /api/gtag → gtag-proxy.mts, /api/m → analytics-collect.mts
- /api/send → umami-collect.mts, /api/ksc → umami-script.mts

Note: PR #4366 was already merged while this session was running. The changes in d8760df are ready to apply on top of main in a follow-up PR.

clubanderson added 3 commits April 2, 2026 21:31

Copilot AI review requested due to automatic review settings April 3, 2026 01:51

kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 3, 2026

kubestellar-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 3, 2026

Copilot started reviewing on behalf of clubanderson April 3, 2026 01:52 View session

Copilot AI reviewed Apr 3, 2026

View reviewed changes

clubanderson assigned Copilot Apr 3, 2026

Copilot started work on behalf of clubanderson April 3, 2026 01:54 View session

clubanderson merged commit 036783a into main Apr 3, 2026
27 of 30 checks passed

kubestellar-prow bot deleted the fix/console-errors branch April 3, 2026 02:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Add MSW catch-all for unmocked API routes#4366

🐛 Add MSW catch-all for unmocked API routes#4366
clubanderson merged 3 commits intomainfrom
fix/console-errors

clubanderson commented Apr 3, 2026 •

edited by Copilot AI

Loading

Uh oh!

kubestellar-prow bot commented Apr 3, 2026

Uh oh!

netlify bot commented Apr 3, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

Copilot AI Apr 3, 2026

Uh oh!

clubanderson commented Apr 3, 2026

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

Copilot AI commented Apr 3, 2026

🔄 Auto-Applying Copilot Code Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	// On Netlify, unhandled /api/* and /health requests fall through to the SPA
	// On Netlify, unhandled /api/* requests fall through to the SPA

Conversation

clubanderson commented Apr 3, 2026 • edited by Copilot AI Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kubestellar-prow bot commented Apr 3, 2026

Uh oh!

netlify bot commented Apr 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubestellarconsole ready!

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

Uh oh!

clubanderson commented Apr 3, 2026

🔄 Auto-Applying Copilot Code Review

Uh oh!

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

Uh oh!

github-actions bot commented Apr 3, 2026

✅ Post-Merge Verification: passed

Uh oh!

Copilot AI commented Apr 3, 2026

🔄 Auto-Applying Copilot Code Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

clubanderson commented Apr 3, 2026 •

edited by Copilot AI

Loading

netlify bot commented Apr 3, 2026 •

edited

Loading