Skip to content

Fix enhancement issues: i18n tabs, misleading AI label, unused deps#5229

Merged
clubanderson merged 3 commits intomainfrom
fix/enhancement-issues-5216-5200-5196
Apr 7, 2026
Merged

Fix enhancement issues: i18n tabs, misleading AI label, unused deps#5229
clubanderson merged 3 commits intomainfrom
fix/enhancement-issues-5216-5200-5196

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

Summary

Closes #5216
Closes #5200
Closes #5196
Closes #5211

Test plan

  • Verify MissionDetailView tab labels render correctly (same English text, now from i18n)
  • Verify ReplaceCardModal "Describe What You Need" tab shows "Smart Suggestions" header with Lightbulb icon instead of "AI-Powered" with Sparkles
  • Verify npm run build passes
  • Verify no runtime errors from removed dependencies

Add useTranslation() and use t() for Install, Uninstall, Update/Upgrade,
and Troubleshooting tab labels and empty-state messages. Add corresponding
translation keys under missions.detail.tabs in common.json.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
The "AI-Powered Creation" tab in ReplaceCardModal uses keyword matching,
not AI. Rename to "Smart Suggestions" with honest description, replace
Sparkles icon with Lightbulb to avoid implying AI capabilities.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
…mpiler (#5196)

React Compiler was disabled but these dependencies remained. Remove both
react-compiler-runtime (dependency) and babel-plugin-react-compiler
(devDependency) since they are no longer used.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings April 7, 2026 13:13
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 7, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 7, 2026

Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 8ca0d41
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69d502f6e4d2650008c48197
😎 Deploy Preview https://deploy-preview-5229.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@clubanderson clubanderson merged commit 5585534 into main Apr 7, 2026
16 of 18 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@kubestellar-prow kubestellar-prow bot deleted the fix/enhancement-issues-5216-5200-5196 branch April 7, 2026 13:13
@kubestellar-prow kubestellar-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Post-merge build verification passed

Both Go and frontend builds compiled successfully against merge commit 5585534ac30f83981a018b5eab61cc7319616db6.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses a set of UX/maintenance cleanup items in the web console: internationalizing Mission detail tab labels, removing “AI” branding from a keyword-matching suggestion flow, and dropping unused React Compiler dependencies.

Changes:

  • Internationalized MissionDetailView tab labels/empty states via useTranslation() and new missions.detail.tabs.* keys.
  • Renamed the Replace Card modal “AI-Powered” UI to “Smart Suggestions”, swapped the icon, and updated related copy/labels.
  • Removed unused react-compiler-runtime and babel-plugin-react-compiler from web dependencies (and updated lockfile).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
web/src/locales/en/common.json Adds missions.detail.tabs.* keys and updates Replace Card modal strings to “Smart Suggestions” wording.
web/src/components/missions/MissionDetailView.tsx Replaces hardcoded tab labels/empty messages with i18n t() calls.
web/src/components/dashboard/ReplaceCardModal.tsx Rebrands the “AI” tab UI to “Smart Suggestions” and replaces Sparkles with Lightbulb.
web/package.json Removes unused React Compiler-related dependencies.
web/package-lock.json Removes corresponding lockfile entries for the removed packages.
Files not reviewed (1)
  • web/package-lock.json: Language not supported

Comment on lines 223 to 227
const tabs: TabDef[] = [
{
id: 'install',
label: 'Install',
label: t('missions.detail.tabs.install'),
icon: Download,
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates the tab labels to use i18n, but MissionDetailView still contains several other user-facing strings hardcoded in English (e.g., "Back to listing", "Preview"/"View Raw", "Improve", default importLabel="Import", etc.). If the intent is to close #5216 (i18n bypass), those strings should also be routed through t() (and added to common.json), or the issue/PR description should be adjusted so we don’t mark the i18n work as complete prematurely.

Copilot uses AI. Check for mistakes.
Comment on lines 91 to 97
const handleAIGenerate = async () => {
if (!nlPrompt.trim()) return
setIsProcessing(true)
setAiSuggestion(null)

// Simulate AI processing
// Simulate processing delay for keyword matching
await new Promise((resolve) => setTimeout(resolve, NAV_AFTER_ANIMATION_MS))
Copy link

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI is now labeled "Smart Suggestions" and the implementation is explicitly keyword matching, but the internal API still uses AI-centric names (handleAIGenerate, aiSuggestion, tab id 'ai', etc.). Renaming these identifiers to reflect the actual behavior would reduce confusion and make future maintenance (e.g., adding a real AI path later) less error-prone.

Copilot uses AI. Check for mistakes.
@clubanderson
Copy link
Copy Markdown
Collaborator Author

🔄 Auto-Applying Copilot Code Review

Copilot code review found 0 code suggestion(s) and 2 general comment(s).

Also address these general comments:

  • web/src/components/missions/MissionDetailView.tsx (line 227): This PR updates the tab labels to use i18n, but MissionDetailView still contains several other user-facing strings hardc
  • web/src/components/dashboard/ReplaceCardModal.tsx (line 97): The UI is now labeled "Smart Suggestions" and the implementation is explicitly keyword matching, but the internal API st

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.


Auto-generated by copilot-review-apply workflow.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

✅ Post-Merge Verification: passed

Commit: 5585534ac30f83981a018b5eab61cc7319616db6
Specs run: Dashboard.spec.ts Missions.spec.ts mission-import.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/24083247571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

3 participants