[sec-check] fix: add npm overrides for markdown-it >=14.1.1 and @xmldom/xmldom >=0.9.10#5764
[sec-check] fix: add npm overrides for markdown-it >=14.1.1 and @xmldom/xmldom >=0.9.10#5764clubanderson wants to merge 1 commit into
Conversation
…mldom >=0.9.10 Fixes GHSA-38c4-r59v-3vqw (markdown-it 14.1.0 ReDoS) and 4 xmldom CVEs in 0.9.9 (GHSA-2v35-w6hq-6mfw, GHSA-f6ww-3ggp-fr8h, GHSA-x6wf-f3px-wcqx, GHSA-j759-j44w-7fr8). Both are transitive deps (markdownlint-cli2 → markdown-it, mermaid → speech-rule-engine → @xmldom/xmldom). Fixes #5763 Signed-off-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellar-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@clubanderson: The following tests failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Pull request overview
This PR adds npm overrides to force patched versions of two vulnerable transitive dependencies used by dev tooling and mermaid-related packages, addressing the security findings in #5763.
Changes:
- Add
overridesformarkdown-itto avoid the vulnerable<14.1.1range. - Add
overridesfor@xmldom/xmldomto avoid the vulnerable<0.9.10range.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "overrides": { | ||
| "markdown-it": ">=14.1.1", | ||
| "@xmldom/xmldom": ">=0.9.10" | ||
| }, |
| "overrides": { | ||
| "markdown-it": ">=14.1.1", | ||
| "@xmldom/xmldom": ">=0.9.10" | ||
| }, |
|
If PR #5737 lands first, this PR can be closed as superseded. If this PR lands first, #5737 will need to be rebased. Recommend merging #5737 first (more comprehensive), then closing this one. — sec-check agent (ACMM L6) |
|
Security Fix
Adds
overridesblock topackage.jsonto force safe versions of two vulnerable transitive dependencies.Vulnerabilities Fixed
markdown-it 14.1.0 → >=14.1.1 (GHSA-38c4-r59v-3vqw)
/*+$/regex in linkify>= 13.0.0, < 14.1.1markdownlint-cli2→markdown-it: 14.1.0@xmldom/xmldom 0.9.9 → >=0.9.10 (4 CVEs)
mermaid→speech-rule-engine→@xmldom/xmldom: 0.9.9Change
Single addition to
package.json:After merging, run
npm installlocally to regeneratepackage-lock.jsonwith the safe versions.Fixes #5763
Filed by sec-check agent (ACMM L6 — full mode, pass 75)