Skip to content

Conversation

@pcbailey
Copy link
Member

@pcbailey pcbailey commented Apr 14, 2025

📝 Description

This PR migrates two of the topology view extensions from the static plugin: console.topology/component/factory and console.topology/data/factory

Jira: https://issues.redhat.com/browse/CNV-56431

Screenshot:

kubevirt-topology--2025-05-27_08-59

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 14, 2025

@pcbailey: This pull request references CNV-56431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

📝 Description

This PR migrates the topology view extensions from the static plugin.

Jira: https://issues.redhat.com/browse/CNV-56431

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from avivtur and metalice April 14, 2025 11:46
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 14, 2025
@pcbailey
Copy link
Member Author

/hold

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 24, 2025

@pcbailey: This pull request references CNV-56431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

📝 Description

This PR migrates two of the topology view extensions from the static plugin: console.topology/component/factory and console.topology/data/factory

Jira: https://issues.redhat.com/browse/CNV-56431

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey changed the title WIP: CNV-56431: Add topology extensions WIP: CNV-56431: Add initial topology extensions Apr 24, 2025
@pcbailey pcbailey force-pushed the add-virtualization-extensions-for-topology branch from 59c40a6 to 7bd181b Compare May 21, 2025 19:25
@pcbailey pcbailey force-pushed the add-virtualization-extensions-for-topology branch 3 times, most recently from 2a2941e to ef79aad Compare May 27, 2025 12:52
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 27, 2025

@pcbailey: This pull request references CNV-56431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

📝 Description

This PR migrates two of the topology view extensions from the static plugin: console.topology/component/factory and console.topology/data/factory

Jira: https://issues.redhat.com/browse/CNV-56431

Screenshot:

kubevirt-topology--2025-05-27_08-59

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pcbailey pcbailey changed the title WIP: CNV-56431: Add initial topology extensions CNV-56431: Add initial topology extensions May 27, 2025
@pcbailey
Copy link
Member Author

/hold cancel

@pcbailey pcbailey changed the title CNV-56431: Add initial topology extensions WIP: CNV-56431: Add initial topology extensions May 27, 2025
@pcbailey pcbailey changed the title WIP: CNV-56431: Add initial topology extensions CNV-56431: Add initial topology extensions May 28, 2025
@pcbailey pcbailey force-pushed the add-virtualization-extensions-for-topology branch from ef79aad to 03fc361 Compare May 28, 2025 12:05
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 30, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 88c16b2 into kubevirt-ui:main May 30, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants