Make start-console script compatible with zsh #2592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metalice
reviewed
Apr 20, 2025
| #!/usr/bin/env bash | ||
| #Please run this script under bash 4+ | ||
| set -euo pipefail | ||
| #!/bin/sh |
Member
Author
There was a problem hiding this comment.
i would like to make it compatible with both
Member
|
not working on my mac first run is with #!/bin/zsh |
Member
Author
|
/retest |
upalatucci
force-pushed
the
start-console-compatible
branch
from
7447a47 to
1dd9784
Compare
pcbailey
reviewed
Jun 4, 2025
start-console.sh
Outdated
| [ -n "$pid" ] && kill -9 "$pid" | ||
|
|
||
|
|
||
| [ "$arg" = "monitoring-plugin" ] then |
Member
There was a problem hiding this comment.
This line needs to be changed back to:
if [ "$arg" = "monitoring-plugin" ]; then
upalatucci
force-pushed
the
start-console-compatible
branch
from
1dd9784 to
f1b2a6a
Compare
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, upalatucci The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/retest |
1 similar comment
Member
Author
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
is not compatible with zsh. Me and others use that