Skip to content

Conversation

@adamviktora
Copy link
Member

@adamviktora adamviktora commented May 27, 2025

📝 Description

Fixes a bug where whole card in Catalog -> InstanceTypes was reloading on project change. Now the loading state is displayed just in the volumes list on project change.

🎥 Demo

Before:

Screen.Recording.2025-05-27.at.12.42.38.mov

After:

Screen.Recording.2025-05-27.at.13.26.05.mov

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 27, 2025

@adamviktora: This pull request references CNV-62314 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

📝 Description

Fixes a bug where whole card in Catalog -> InstanceTypes was reloading on project change. Now the loading state is displayed just in the volumes list on project change.

🎥 Demo

Before:

Screen.Recording.2025-05-27.at.12.42.38.mov

After:

Screen.Recording.2025-05-27.at.12.42.10.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from lkladnit and rszwajko May 27, 2025 10:45
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 27, 2025
@upalatucci
Copy link
Member

@adamviktora do you think we can use a table skeleton loader instead of spinner?

@adamviktora
Copy link
Member Author

adamviktora commented May 27, 2025

@upalatucci Ok, I had a skeleton there first but then I decided to go with spinner :D because we don't know how many lines will be loaded, but I will do something like 3 lines

EDIT: just found out there is a https://www.patternfly.org/component-groups/status-and-state-indicators/skeleton-table, that's probably what you meant?

@adamviktora adamviktora force-pushed the catalog-fix-card-reload branch from 98226d1 to 94f945c Compare May 27, 2025 11:27
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 27, 2025

@adamviktora: This pull request references CNV-62314 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

📝 Description

Fixes a bug where whole card in Catalog -> InstanceTypes was reloading on project change. Now the loading state is displayed just in the volumes list on project change.

🎥 Demo

Before:

Screen.Recording.2025-05-27.at.12.42.38.mov

After:

Screen.Recording.2025-05-27.at.13.26.05.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@adamviktora adamviktora force-pushed the catalog-fix-card-reload branch from 94f945c to 92b5889 Compare May 27, 2025 13:30
@adamviktora adamviktora requested a review from rszwajko May 27, 2025 13:31
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamviktora, rszwajko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adamviktora,rszwajko]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 47e0284 into kubevirt-ui:main May 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants