-
Notifications
You must be signed in to change notification settings - Fork 52
CNV-62314: fix layout reload on project change in Catalog #2700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CNV-62314: fix layout reload on project change in Catalog #2700
Conversation
|
@adamviktora: This pull request references CNV-62314 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@adamviktora do you think we can use a table skeleton loader instead of spinner? |
|
@upalatucci Ok, I had a skeleton there first but then I decided to go with spinner :D because we don't know how many lines will be loaded, but I will do something like 3 lines EDIT: just found out there is a https://www.patternfly.org/component-groups/status-and-state-indicators/skeleton-table, that's probably what you meant? |
98226d1 to
94f945c
Compare
|
@adamviktora: This pull request references CNV-62314 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
src/views/catalog/CreateFromInstanceTypes/components/BootableVolumeList/BootableVolumeList.tsx
Outdated
Show resolved
Hide resolved
94f945c to
92b5889
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adamviktora, rszwajko The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
📝 Description
Fixes a bug where whole card in Catalog -> InstanceTypes was reloading on project change. Now the loading state is displayed just in the volumes list on project change.
🎥 Demo
Before:
Screen.Recording.2025-05-27.at.12.42.38.mov
After:
Screen.Recording.2025-05-27.at.13.26.05.mov