Skip to content

Conversation

@adamviktora
Copy link
Member

📝 Description

Fixes a bug in VM details configuration, where upon searching the expandable section was opening and closing back and forth.

Bug was that expandURLHash expected a (val: boolean) => void type. The return type of useToggle was wrong, although it was specified as Dispatch<SetStateAction<boolean>> a () => void was returned instead.

🎥 Demo

Before:

Screen.Recording.2025-06-02.at.14.20.33.mov

After:

Screen.Recording.2025-06-02.at.14.13.25.mov

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 2, 2025

@adamviktora: This pull request references CNV-57780 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

Details

In response to this:

📝 Description

Fixes a bug in VM details configuration, where upon searching the expandable section was opening and closing back and forth.

Bug was that expandURLHash expected a (val: boolean) => void type. The return type of useToggle was wrong, although it was specified as Dispatch<SetStateAction<boolean>> a () => void was returned instead.

🎥 Demo

Before:

Screen.Recording.2025-06-02.at.14.20.33.mov

After:

Screen.Recording.2025-06-02.at.14.13.25.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gouyang and vojtechszocs June 2, 2025 12:21
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 2, 2025
@pcbailey
Copy link
Member

pcbailey commented Jun 3, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adamviktora, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [adamviktora,pcbailey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member

/retest

1 similar comment
@upalatucci
Copy link
Member

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 0bb8b80 into kubevirt-ui:main Jun 4, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants