Skip to content

Conversation

@pcbailey
Copy link
Member

@pcbailey pcbailey commented Jun 2, 2025

📝 Description

This PR adds the extension for the VM Details panel in the side drawer.

Jira: https://issues.redhat.com/browse/CNV-56431

🎥 Screenshot

topology-details-panel--2025-06-02_08-22

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Jun 2, 2025

@pcbailey: This pull request references CNV-56431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

Details

In response to this:

📝 Description

This PR adds the extension for the VM Details panel in the side drawer.

Jira: https://issues.redhat.com/browse/CNV-56431

🎥 Screenshot

topology-details-panel--2025-06-02_08-22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rszwajko and vojtechszocs June 2, 2025 12:30
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Jun 2, 2025
@pcbailey pcbailey force-pushed the add-vm-details-panel-topology-extension branch 3 times, most recently from edcc2ab to 0492a13 Compare June 3, 2025 12:14
@pcbailey pcbailey changed the title WIP: CNV-56431: Add VM Details panel topology extension CNV-56431: Add VM Details panel topology extension Jun 3, 2025
@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 4, 2025
@pcbailey pcbailey force-pushed the add-vm-details-panel-topology-extension branch from 0492a13 to db35401 Compare June 4, 2025 11:33
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Jun 4, 2025
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 4, 2025
@pcbailey
Copy link
Member Author

pcbailey commented Jun 4, 2025

/retest

@pcbailey pcbailey force-pushed the add-vm-details-panel-topology-extension branch from db35401 to db372fb Compare June 5, 2025 13:28
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Jun 5, 2025
@pcbailey pcbailey force-pushed the add-vm-details-panel-topology-extension branch from db372fb to 5d243ae Compare June 5, 2025 13:35
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 5, 2025
@pcbailey pcbailey force-pushed the add-vm-details-panel-topology-extension branch from 5d243ae to 297879f Compare June 5, 2025 14:38
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Jun 5, 2025
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 5, 2025
@pcbailey pcbailey force-pushed the add-vm-details-panel-topology-extension branch from 297879f to fec582c Compare June 5, 2025 14:47
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label Jun 5, 2025
@upalatucci
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Jun 5, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [pcbailey,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0f1b5df into kubevirt-ui:main Jun 5, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants