fix: remove cosign v2 double-signing, use v3 bundle format only#280
Open
mateenali66 wants to merge 1 commit intokubewarden:mainfrom
Open
fix: remove cosign v2 double-signing, use v3 bundle format only#280mateenali66 wants to merge 1 commit intokubewarden:mainfrom
mateenali66 wants to merge 1 commit intokubewarden:mainfrom
Conversation
All known verification tools now support the cosign v3 bundle format: - ArtifactHub confirmed v3 support (artifacthub/hub#4684) - slsactl updated to use sigstore/cosign/v3 v3.0.5 (see go.mod) - hauler updated cosign fork to 3.0.4 Remove the legacy --new-bundle-format=false signing steps from container-build, merge-multiarch, and policy-release actions. cosign v3 defaults to the bundle format so no explicit flag is needed. Closes kubewarden/adm-controller#1614 Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the legacy cosign v2 double-signing from the composite actions. All known verification tools now support the cosign v3 bundle format, so signing twice is no longer needed.
Tools verified
github.com/sigstore/cosign/v3 v3.0.5in go.modChanges
container-build/action.yml: removed v2 signing step, kept singlecosign sign(v3 default)merge-multiarch/action.yml: samepolicy-release/action.yml: same (two signing blocks, both cleaned up)cosign v3 defaults to the bundle format, so no explicit flags needed.
Closes kubewarden/adm-controller#1614