Replace hardcoded project statuses with dynamic detection#4
Merged
Conversation
Remove fixed status union types (\"Backlog\", \"Ready\", \"In progress\", etc.) and implement dynamic status handling that works with any GitHub Project V2 status field values. Add hash-based color assignment using a predefined palette to ensure consistent badge styling across different project configurations. fix #3
Contributor
|
/gemini review |
Contributor
|
/gemini review |
1 similar comment
Owner
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully replaces the hardcoded project statuses with a dynamic system. The changes are well-implemented, removing the rigid ProjectStatus type and associated CSS classes in favor of a flexible string-based status and a hash-based dynamic color assignment for badges. My feedback focuses on improving the readability and maintainability of the new hashing function in src/content.ts by adhering more closely to the repository's coding style guidelines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove fixed status union types ("Backlog", "Ready", "In progress", etc.) and implement dynamic status handling that works with any GitHub Project V2 status field values. Add hash-based color assignment using a predefined palette to ensure consistent badge styling across different project configurations.
fix #3