feat(ci): sign and notarize macOS binaries on Linux with rcodesign#17
Merged
feat(ci): sign and notarize macOS binaries on Linux with rcodesign#17
Conversation
Replaces the GitHub-hosted macOS runner for signing/notarization with a Linux runner using the kula/rcodesign:alpine container. - Signing uses rcodesign with --code-signature-flags runtime (hardened runtime). The Developer ID cert is supplied directly from the .p12, so no keychain setup is needed. - Notarization uses rcodesign notary-submit --wait with an App Store Connect API key JSON blob assembled at runtime via rcodesign encode-app-store-connect-api-key. - Continues to sign both ship-darwin-arm64 and ship-darwin-amd64.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kula/rcodesign:alpinecontainer.rcodesignwith--code-signature-flags runtime(hardened runtime). The Developer ID cert is supplied directly from the.p12, so no keychain setup is needed.rcodesign notary-submit --waitwith an App Store Connect API key JSON blob assembled at runtime viarcodesign encode-app-store-connect-api-key— replaces the Apple ID + app-specific password approach.setup-macos-signingandcleanup-macos-signingcomposite actions (no longer needed).docs/MACOS_SIGNING.mdto reflect the new flow.Why
Org-level secrets/variables
All required secrets and variables are already provisioned at the kula-app org level — no setup required:
Secrets (existing):
DEVELOPER_ID_P12_BASE64,DEVELOPER_ID_PASSWORD,APPLE_NOTARIZATION_APP_STORE_CONNECT_API_KEY_P8_BASE64Variables (existing):
APPLE_NOTARIZATION_APP_STORE_CONNECT_API_KEY_ID,APPLE_NOTARIZATION_APP_STORE_CONNECT_API_ISSUER_IDThe legacy Apple-ID secrets/vars (
APPLE_NOTARIZATION_APPLE_ID_PASSWORD,APPLE_NOTARIZATION_APPLE_ID_USERNAME,APPLE_NOTARIZATION_TEAM_ID,APPLE_NOTARIZATION_SIGNING_IDENTITY) can be removed from the org once every repo using them has migrated.Caveats
codesign(segment flag / CodeRequirements encoding). They verify fine, but it is worth downloading a signed build from CI and runningcodesign -dvv+spctl -a -vv -t installon a real Mac before treating this as the canonical flow.Test plan
codesign -dvv <binary>→ Authority chain shows Developer ID Application + Developer ID CA + Apple Root CA, flags includeruntime, Timestamp present.spctl -a -vv -t install <binary>→accepted,source=Notarized Developer ID../<binary> --versionruns without Gatekeeper warning.