Skip to content

Conversation

@Icarus9913
Copy link
Contributor

Motivation

While implementing the golang error type wrapping for store error detection, it's recommended to supplement a MADR for that from the triage-comment: #2604 (comment)

Fix #2604

Signed-off-by: Icarus Wu <icaruswu66@qq.com>
@Icarus9913 Icarus9913 requested a review from a team as a code owner May 7, 2025 07:12
@Icarus9913 Icarus9913 added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label May 7, 2025
@Icarus9913 Icarus9913 requested review from Automaat and slonka May 7, 2025 07:12
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@slonka slonka requested review from a team and Automaat and removed request for a team May 12, 2025 12:35
Icarus9913 and others added 2 commits May 22, 2025 11:13
Co-authored-by: Charly Molter <charly@molter.io>
Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Signed-off-by: Icarus Wu <icaruswu66@qq.com>
Automaat
Automaat previously approved these changes May 26, 2025
slonka
slonka previously approved these changes Jun 2, 2025
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one Q

@Icarus9913 Icarus9913 dismissed stale reviews from slonka and Automaat via a8c0259 June 4, 2025 08:51
@Icarus9913 Icarus9913 enabled auto-merge (squash) June 4, 2025 08:52
@Icarus9913 Icarus9913 merged commit 3220f15 into kumahq:master Jun 4, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use Go error type wrapping for store error detection

5 participants