Skip to content

Conversation

@jijiechen
Copy link
Member

Motivation

Adding the ability to customize docker volumes and arguments when installing Kuma on Universal. With this ability, we can attach certificates and other resources in E2E tests.

Implementation information

  • Introducing helper method WithCPDockerVolumes to test framework
  • Introducing helper method WithCPDockerRunOptions to test framework (to allow specify docker arguments like --ip)

Supporting documentation

An enahancement to #13301

Changelog: skip

jijiechen added 4 commits May 7, 2025 10:40
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
Signed-off-by: Jay Chen <1180092+jijiechen@users.noreply.github.com>
@jijiechen jijiechen requested a review from a team as a code owner May 8, 2025 04:50
@jijiechen jijiechen requested review from Automaat and lukidzi May 8, 2025 04:50
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2025

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@jijiechen jijiechen merged commit 3661db1 into kumahq:master May 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants