Skip to content

Conversation

@kunitoki
Copy link
Owner

@kunitoki kunitoki commented Mar 22, 2025

This pull request introduces several significant changes to the examples/render/source/main.cpp and modules/yup_gui files, focusing on refactoring the Artboard class and related functionalities. The most important changes include the introduction of the ArtboardFile class, refactoring the Artboard class to use ArtboardFile, and adding new input handling methods.

Changes to Artboard and ArtboardFile:

  • Introduced the ArtboardFile class to encapsulate the handling of artboard files, including methods for loading from files and streams.
  • Refactored the Artboard class to use ArtboardFile instead of directly handling rive::File. This includes adding a constructor and setFile method that accept ArtboardFile.
  • Removed old methods loadFromFile and loadFromStream from Artboard and replaced them with setFile and clear methods.

Input Handling Enhancements:

  • Added new methods to the Artboard class for handling boolean, number, and trigger inputs, including hasBoolInput, setBoolInput, hasNumberInput, setNumberInput, hasTriggerInput, and triggerInput.
  • Implemented methods to get and set all inputs, and to set individual inputs.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.79%. Comparing base (1be9bf5) to head (2dcdb6c).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   42.76%   42.79%   +0.03%     
==========================================
  Files         304      304              
  Lines       30091    30091              
==========================================
+ Hits        12868    12878      +10     
+ Misses      17223    17213      -10     
Files with missing lines Coverage Δ
modules/yup_core/time/yup_Time.cpp 82.57% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1be9bf5...2dcdb6c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki merged commit a3abfa2 into main Jun 18, 2025
38 checks passed
@kunitoki kunitoki deleted the dev/improved_artboard branch June 18, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants