-
Notifications
You must be signed in to change notification settings - Fork 15
Improved artboard classes #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # modules/yup_gui/artboard/yup_Artboard.cpp
# Conflicts: # modules/yup_gui/artboard/yup_Artboard.cpp
# Conflicts: # modules/yup_graphics/primitives/yup_Path.cpp
# Conflicts: # examples/render/source/main.cpp # modules/yup_gui/artboard/yup_Artboard.cpp # modules/yup_gui/yup_gui.cpp # modules/yup_gui/yup_gui.h
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #43 +/- ##
==========================================
+ Coverage 42.76% 42.79% +0.03%
==========================================
Files 304 304
Lines 30091 30091
==========================================
+ Hits 12868 12878 +10
+ Misses 17223 17213 -10
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This pull request introduces several significant changes to the
examples/render/source/main.cppandmodules/yup_guifiles, focusing on refactoring theArtboardclass and related functionalities. The most important changes include the introduction of theArtboardFileclass, refactoring theArtboardclass to useArtboardFile, and adding new input handling methods.Changes to
ArtboardandArtboardFile:ArtboardFileclass to encapsulate the handling of artboard files, including methods for loading from files and streams.Artboardclass to useArtboardFileinstead of directly handlingrive::File. This includes adding a constructor andsetFilemethod that acceptArtboardFile.loadFromFileandloadFromStreamfromArtboardand replaced them withsetFileandclearmethods.Input Handling Enhancements:
Artboardclass for handling boolean, number, and trigger inputs, includinghasBoolInput,setBoolInput,hasNumberInput,setNumberInput,hasTriggerInput, andtriggerInput.