Skip to content

Conversation

@kunitoki
Copy link
Owner

@kunitoki kunitoki commented Jun 13, 2025

image
image
image
image

kunitoki and others added 13 commits June 6, 2025 15:42
# Conflicts:
#	examples/graphics/source/main.cpp
#	modules/yup_events/messages/yup_MessageManager.cpp
#	modules/yup_graphics/fonts/yup_StyledText.h
#	modules/yup_gui/component/yup_ComponentNative.h
#	modules/yup_gui/desktop/yup_Desktop.h
#	modules/yup_gui/native/yup_Windowing_sdl2.cpp
#	modules/yup_gui/yup_gui.cpp
#	modules/yup_gui/yup_gui.h
@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 40.18801% with 1018 lines in your changes missing coverage. Please review.

Project coverage is 43.88%. Comparing base (533064e) to head (d087d55).

Files with missing lines Patch % Lines
modules/yup_gui/menus/yup_PopupMenu.cpp 42.80% 310 Missing ⚠️
...ules/yup_gui/themes/theme_v1/yup_ThemeVersion1.cpp 3.67% 131 Missing ⚠️
modules/yup_gui/native/yup_Windowing_sdl2.cpp 2.50% 117 Missing ⚠️
...yup_graphics/native/yup_GraphicsContext_opengl.cpp 0.00% 104 Missing ⚠️
modules/yup_gui/component/yup_Component.cpp 54.38% 104 Missing ⚠️
modules/yup_gui/widgets/yup_ComboBox.cpp 56.88% 72 Missing ⚠️
modules/yup_gui/desktop/yup_Desktop.cpp 12.50% 63 Missing ⚠️
modules/yup_gui/buttons/yup_SwitchButton.cpp 65.75% 25 Missing ⚠️
modules/yup_gui/buttons/yup_ToggleButton.cpp 62.50% 18 Missing ⚠️
modules/yup_graphics/fonts/yup_Font.cpp 0.00% 16 Missing ⚠️
... and 14 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
- Coverage   45.04%   43.88%   -1.16%     
==========================================
  Files         346      399      +53     
  Lines       31307    36078    +4771     
==========================================
+ Hits        14101    15834    +1733     
- Misses      17206    20244    +3038     
Files with missing lines Coverage Δ
modules/yup_core/containers/yup_Variant.cpp 80.21% <ø> (+0.56%) ⬆️
...odules/yup_events/messages/yup_ApplicationBase.cpp 58.00% <100.00%> (+58.00%) ⬆️
modules/yup_events/messages/yup_ApplicationBase.h 60.00% <ø> (+40.00%) ⬆️
modules/yup_events/messages/yup_MessageManager.cpp 48.40% <100.00%> (+35.69%) ⬆️
modules/yup_events/messages/yup_MessageManager.h 60.00% <ø> (+20.00%) ⬆️
modules/yup_graphics/fonts/yup_Font.h 66.66% <ø> (+16.66%) ⬆️
modules/yup_graphics/graphics/yup_Graphics.h 86.20% <ø> (ø)
...ules/yup_graphics/primitives/yup_AffineTransform.h 96.55% <100.00%> (-1.57%) ⬇️
modules/yup_graphics/primitives/yup_Line.h 100.00% <ø> (ø)
modules/yup_graphics/primitives/yup_Path.h 100.00% <ø> (ø)
... and 41 more

... and 41 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 533064e...d087d55. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki changed the title Popup menus PopupMenu, ComboBox and Other Widgets Jun 30, 2025
@kunitoki kunitoki merged commit 3e2417c into main Jul 1, 2025
@kunitoki kunitoki deleted the dev/popup_menu branch July 1, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants