Skip to content

feat: Add x/oauth2/google/externalaccount/aws/ecs package for Google Workload Identity Federation via ECS Metadata#228

Merged
ginokent merged 1 commit intomainfrom
feat-add-x-oauth2-google-externalaccount-package
Jul 23, 2024
Merged

feat: Add x/oauth2/google/externalaccount/aws/ecs package for Google Workload Identity Federation via ECS Metadata#228
ginokent merged 1 commit intomainfrom
feat-add-x-oauth2-google-externalaccount-package

Conversation

@ginokent
Copy link
Member

Ticket / Issue Number

Note
Please fill in the ticket or issue number.

Example:

#3

What's changed

Note
Please explain what changes this pull request will make.

Example:

  • Added functionality to perform 'bar' on 'foo'.

Check List

  • Assign labels
  • Add appropriate test cases

Remark

Note
Please provide additional remarks if necessary.

@ginokent ginokent self-assigned this Jul 22, 2024
@github-actions github-actions bot added the feat A new feature label Jul 22, 2024
@ginokent ginokent force-pushed the feat-add-x-oauth2-google-externalaccount-package branch 2 times, most recently from d9edf08 to 5a83c00 Compare July 23, 2024 04:46
@ginokent ginokent changed the title feat: Add x/oauth2/google/externalaccount package for Google Workload Identity Federation via ECS Metadata feat: Add x/oauth2/google/externalaccount/aws/ecs package for Google Workload Identity Federation via ECS Metadata Jul 23, 2024
@codecov
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.63%. Comparing base (c8a6774) to head (e822bde).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   91.26%   91.63%   +0.37%     
==========================================
  Files          99      100       +1     
  Lines        4898     4900       +2     
==========================================
+ Hits         4470     4490      +20     
+ Misses        428      408      -20     
- Partials        0        2       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ginokent ginokent force-pushed the feat-add-x-oauth2-google-externalaccount-package branch 3 times, most recently from f759e17 to c79a443 Compare July 23, 2024 13:53
…Workload Identity Federation via ECS Metadata
@ginokent ginokent force-pushed the feat-add-x-oauth2-google-externalaccount-package branch from c79a443 to e822bde Compare July 23, 2024 13:54
@ginokent ginokent marked this pull request as ready for review July 23, 2024 15:34
@ginokent ginokent requested a review from a team as a code owner July 23, 2024 15:34
@ginokent ginokent added this pull request to the merge queue Jul 23, 2024
Merged via the queue into main with commit 75f331b Jul 23, 2024
@ginokent ginokent deleted the feat-add-x-oauth2-google-externalaccount-package branch July 23, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat A new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants