Adding Objective-C attributes to delegate and main class to turn Objective-C runtime accessible to Nativescript#95
Merged
kuraydev merged 1 commit intokuraydev:masterfrom Oct 9, 2020
Conversation
This commit adds @objc attribute annotation to StompClientLibDelegate and @objcMembers to StompClientLib to turn Objective-C runtime accessible to nativescript applications
Owner
|
Hello again @dfborba :) |
kuraydev
approved these changes
Oct 9, 2020
Owner
Author
|
Amazing @WrathChaos! Happy to contribute! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Team, we have a project which needs to connect through WebSocket with STOMP protocol for Nativescript applications;
But to Nativescript be able to access Swift classes it needs to be able to access the Objective-C runtime. So in order to achieve it I've changed the StompClientLib and added the @objc attribute annotation to StompClientLibDelegate and @objcMembers to StompClientLib, so these classes and its attributes/methods and etc can be access from Nativescript.
Please, review this code and let me know if these changes will not affecting any other project that use this library.
Looking forward to have these changes approved 👍
Thanks.