Skip to content

Ensure that we stop the projection before we attempt to delete it #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jen20 merged 2 commits into from
Feb 4, 2015
Merged

Ensure that we stop the projection before we attempt to delete it #56

jen20 merged 2 commits into from
Feb 4, 2015

Conversation

@pgermishuys
Copy link
Contributor

@pgermishuys pgermishuys commented Feb 3, 2015

  1. Before deleting a projection, we need to ensure that it's stopped first.
  2. We will now disable the "delete" button if a projection is running
  3. A tooltip has been added to explain why the "delete" projection link has been disabled"

There is accompanying server work on https://github.com/EventStore/EventStore/tree/delete-running-projection that will ensure that a running projection may not be deleted.

Fixes #44

jen20 added a commit that referenced this pull request Feb 4, 2015
@jen20
Merge pull request #56 from EventStore/stop-projection-before-delete
a3e9e7b 
Ensure that we stop the projection before we attempt to delete it
@jen20 jen20 merged commit a3e9e7b into dev Feb 4, 2015
@jen20
Copy link
Contributor

jen20 commented Feb 4, 2015

👍

@jen20 jen20 deleted the stop-projection-before-delete branch February 4, 2015 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pgermishuys @jen20