This repository was archived by the owner on Oct 10, 2025. It is now read-only.
Move rel tables into rel group #5226
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5226 +/- ##
==========================================
- Coverage 86.57% 86.55% -0.02%
==========================================
Files 1410 1410
Lines 61953 61987 +34
Branches 7603 7613 +10
==========================================
+ Hits 53634 53654 +20
- Misses 8144 8158 +14
Partials 175 175 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark ResultMaster commit hash:
|
Benchmark ResultMaster commit hash:
|
andyfengHKU
suggested changes
Apr 14, 2025
| } | ||
| } | ||
| localState->dataChunkCollection->append(outputChunk); | ||
| outputChunk.resetAuxiliaryBuffer(); |
Contributor
There was a problem hiding this comment.
Not related to this PR. But reset state usually happens before append (actually mostly at the start of the function.)
| std::vector<common::ColumnEvaluateType> columnEvaluateTypes; | ||
| std::unique_ptr<ExtraBoundCopyFromInfo> extraInfo; | ||
|
|
||
| explicit BoundCopyFromInfo(catalog::TableCatalogEntry* tableEntry) |
Contributor
There was a problem hiding this comment.
Where are we using this constructor?
Contributor
Author
There was a problem hiding this comment.
It's used inside getPhysicalPlan within create_hnsw_index.cpp.
Benchmark ResultMaster commit hash:
|
Benchmark ResultMaster commit hash:
|
andyfengHKU
force-pushed
the
rel-group
branch
2 times, most recently
from
330f78b to
9fd6cb2
Compare
Benchmark ResultMaster commit hash:
|
andyfengHKU
approved these changes
Apr 25, 2025
Benchmark ResultMaster commit hash:
|
Contributor
|
Duplicate with #5280 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #5158.