Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

Update kuzzle-sdk#2

Merged
scottinet merged 4 commits intomasterfrom
update-kuzzle-sdk
Feb 28, 2019
Merged

Update kuzzle-sdk#2
scottinet merged 4 commits intomasterfrom
update-kuzzle-sdk

Conversation

@Aschen
Copy link
Copy Markdown
Contributor

@Aschen Aschen commented Feb 27, 2019

What does this PR do ?

Updates cucumber to use the latest version of the SDK

How should this be manually tested?

npm run functional-testing

@Aschen Aschen self-assigned this Feb 27, 2019
Copy link
Copy Markdown
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to increase the version number if you want to merge directly on the master branch: run npm version patch and push the result on github

@Aschen
Copy link
Copy Markdown
Contributor Author

Aschen commented Feb 28, 2019

npm version patch

I didn't know this command to upgrade the package.json version !
Done.

@scottinet
Copy link
Copy Markdown
Contributor

This command also updates the version number in the package-lock.json file, which is handy 🙂

Copy link
Copy Markdown
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that you forgot to push the npm version patch result.

@scottinet scottinet merged commit d2a80b6 into master Feb 28, 2019
@scottinet scottinet deleted the update-kuzzle-sdk branch February 28, 2019 13:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants