Skip to content
This repository was archived by the owner on Sep 28, 2022. It is now read-only.

Add document:delete#63

Merged
y-abs merged 10 commits into
3-devfrom
KZL-1350-document-delete
Mar 2, 2020
Merged

Add document:delete#63
y-abs merged 10 commits into
3-devfrom
KZL-1350-document-delete

Conversation

@y-abs
Copy link
Copy Markdown
Contributor

@y-abs y-abs commented Feb 21, 2020

What does this PR do ?

This PR implements the document:delete method with its unit tests.

How should this be manually tested?

Clone this branch and run unit tests
./gradlew test

When it succeed, compile it

./gradlew jar

Initiate another java project by adding the compiled SDK as a dependency.

Then, run Kuzzle, create an index nyc-open-data and a yellow-taxi collection in the admin console. Create a document with id some-id
Finally, run this code

import io.kuzzle.sdk.*;
import io.kuzzle.sdk.Options.KuzzleOptions;
import io.kuzzle.sdk.Options.Protocol.WebSocketOptions;
import io.kuzzle.sdk.Protocol.WebSocket;

import java.util.concurrent.ConcurrentHashMap;

public class deleteDocument {
    private static Kuzzle kuzzle;

    public static void main(String[] args) {
        WebSocketOptions opts = new WebSocketOptions();
        opts.setAutoReconnect(true).setConnectionTimeout(42000);

        try {
            WebSocket ws = new WebSocket("localhost", opts);

            kuzzle = new Kuzzle(ws, (KuzzleOptions) null);

            kuzzle.connect();

            ConcurrentHashMap<String, Object> response =
            kuzzle.getDocumentController().delete("nyc-open-data", "yellow-taxi", "some-id")
            .get();
            System.out.println(response);
        }  catch (Exception e) {
            e.printStackTrace();
        }

        kuzzle.disconnect();
    }
};

The document should be properly deleted with its id as request response

@y-abs y-abs self-assigned this Feb 21, 2020
Copy link
Copy Markdown
Contributor

@scottinet scottinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also report changes requested in #55, #59 and #61

@y-abs y-abs requested a review from scottinet February 26, 2020 16:28
Comment thread doc/3/controllers/document/delete/index.md Outdated
Co-Authored-By: Adrien Maret <amaret93@gmail.com>

import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ConcurrentHashMap;
import java.util.UUID;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused import?

@y-abs y-abs merged commit 8085248 into 3-dev Mar 2, 2020
@y-abs y-abs deleted the KZL-1350-document-delete branch March 2, 2020 11:51
@jenow jenow mentioned this pull request May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants