-
Notifications
You must be signed in to change notification settings - Fork 17
Release 6.2.7 #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Release 6.2.7 #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description The current [SearchResult](https://docs.kuzzle.io/sdk/js/6/core-classes/search-result) documentation contains inconsistencies, spelling errors, and the comments in the snippet examples are off. Also, the introduction page seems overkill for that class. This PR rewrites most of that documentation.
## What does this PR do? The `kuzzle.connected` property which delegate to the protocol was testing a wrong `protocol.state` value (`'online'` instead of `'connected'`).
## What does this PR do? `v6` version of #450 Remove the local check of the arguments since now we have specifics errors code sent by Kuzzle. ### Other changes - Add error codes `id` and `code` properties to `KuzzleError`
## What does this PR do? This getting-started has been added to the documentation before but removed because vuepress can't build with it. It was approved in those PR : #405 and #406 Add VueJS getting started without vuex to SDK JS6 documentation. Resolve the build problem of the vuepress doc (Vuepress tried to build .vue files of the getting-started and crash) by adding symlink.  :warning: need to add following line in doc/6/getting-started/vuejs/standalone/index.md line 14 after merge: ``` You can find the full code of this guide [here](https://github.com/kuzzleio/sdk-javascript/tree/6-dev/doc/6/getting-started/vuejs/standalone).```:warning: ### How should this be manually tested? See documentation: - Step 1 : npm run doc prepare - Step 2 : npm run doc-dev Test getting started project (You'll need the CYPRESS_RECORD_KEY as environment variable) - Step 1 : Get a Kuzzle running without anonymous restrictions - Step 2 : cd doc/6/getting-started/vuejs && npm ci - Step 3 : npm run serve-standalone - Step 4 : npm run test ### Other changes / ### Boyscout /
## What does this PR do? Add Kuzzle React getting-started. This getting-started have been merge in the last doc [#291](kuzzleio/documentation#291) The last getting started app was builted progressively and some code was rewrite during the reading. I had to rewrite lot of parts to remove that because it implicated some untested lines. I avoid hard snippets written in the readme too. I removed the tested snippets and add cypress to test the app globally. The app use the current 6-dev sdk version with the ugly post-install line in `doc/6/getting-started/.react/package.json` ### How should this be manually tested? - Step 0 : Kuzzle running stack - Step 1 : cd doc/6/getting-started/.react - Step 2 : yarn install - Step 3 : yarn start & (if error add `SKIP_PREFLIGHT_CHECK=true`) - Step 4 : npm run test ### Other changes / ### Boyscout /
# Description If `autoReconnect` is true, the SDK tries to reconnect every `reconnectionDelay` milliseconds. If executed within a browser, the SDK can know if the browser has access to some kind of network: if it's marked as "offline", then there is no point retrying to connect, and this might even be harmful in some situations. For instance, browsers switch to offline if a laptop lid is closed, or if a mobile phone screen is turned off. So continuing to connect is just a useless consumption of battery power. This PR stops the reconnection loop and instead waits for the browser to switch to "online" again before resuming its reconnection attempts.
# [6.2.6](https://github.com/kuzzleio/sdk-javascript/releases/tag/6.2.6) (2019-11-05) #### Enhancements - [ [#456](#456) ] Do not try to reconnect if the browser is offline ([scottinet](https://github.com/scottinet)) - [ [#451](#451) ] Remove local checks for arguments ([Aschen](https://github.com/Aschen)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.2.7 (2019-11-05)
Bug fixes
Enhancements
Others