Able to execute document search as GET http method

[Yoann-Abbes]

What does this PR do?

Jira ticket

This PR provides the possibility to execute a document:search with the GET http verb

How should this be manually tested?

Create a nyc-open-data' index and yellow-taxi collection.
Create some files with 2 containing field {name:"ok"}
Execute this code

Remove the verb option and/or change it to POST and re-execute the code

By default, document:search is still POST

const { Kuzzle, Http } = require('kuzzle-sdk');

const kuzzle = new Kuzzle(
  new Http(`localhost`, { port: 7512})
);

async function main () {

  try {
  	await kuzzle.connect();

        const response = await kuzzle.document.search(
      'nyc-open-data',
      'yellow-taxi',
      {
        query:{
            term: {
              name: 'ok'
            }
          }
        },{verb: 'GET'}
    );

    console.log(`Successfully get ${response.total} documents`);
  } catch (error) {
    console.error(error);
  }
}

main()

Other changes

update Mocha to 7.2.0
update codecov to 3.7.0

Boyscout

Removes an unused url who was in conflict with collection:update url
Fix eslint version for the documentation CI

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (7-dev@d877d6f). Click here to learn what that means.
The diff coverage is 87.50%.

@@           Coverage Diff            @@
##             7-dev     #514   +/-   ##
========================================
  Coverage         ?   95.57%           
========================================
  Files            ?       32           
  Lines            ?     1310           
  Branches         ?        0           
========================================
  Hits             ?     1252           
  Misses           ?       58           
  Partials         ?        0           

Impacted Files	Coverage Δ
src/protocols/abstract/Base.js	92.30% <50.00%> (ø)
src/controllers/Document.js	95.16% <100.00%> (ø)
src/protocols/Http.js	91.08% <100.00%> (ø)
src/protocols/WebSocket.js	100.00% <100.00%> (ø)
src/core/searchResult/Document.js	100.00% <0.00%> (ø)
src/core/security/Role.js	80.00% <0.00%> (ø)
src/controllers/Security.js	97.05% <0.00%> (ø)
src/controllers/Bulk.js	100.00% <0.00%> (ø)
src/core/searchResult/User.js	100.00% <0.00%> (ø)
... and 26 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d877d6f...4fb7d3b. Read the comment docs.

[scottinet]

Circular dependency: this PR is required by kuzzleio/kuzzle#1629, but kuzzleio/kuzzle#1629 requires it for the bugfix.

This is impossible to release properly.

You should split this PR in two parts: first the bugfix, and then, once a new version of kuzzle containing the fixed SDK version is released, the other part with the new ability to use document:search using the GET verb.

[Aschen]

You don't need to pass the verb as an argument since the verb option on query will change the http verb

Suggested change

	for (const opt of ['from', 'size', 'scroll', 'verb']) {
	for (const opt of ['from', 'size', 'scroll']) {

[Aschen]

It would be better to have a name property on the protocol objects

[Yoann-Abbes]

yes thanks, I was wondering

[scottinet]

We prefix properties with an underscore as a convention for private properties. You should add a getter, like what's done for other properties.

[scottinet]

Seriously?
You did add the getter, but you still use the class "private" property directly...

[Yoann-Abbes]

Seriously?
You did add the getter, but you still use the class "private" property directly...

sorry, went too fast