Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Jul 14, 2020

What does this PR do?

Adds Typescript support for the AuthController.

I took the descriptions from the documentation.

How should this be manually tested?

Build and pack the SDK: npm run build && npm pack

Then init a Node project and add this dependency:

{
  ...
  "dependencies": {
    "kuzzle-sdk": "file:kuzzle-sdk-7.2.0.tgz"
  }
}

Then create a test.ts file with the following and try to use the controller (just for the auto-completion)

Other changes

Boyscout

@codecov
Copy link

codecov bot commented Jul 16, 2020

Codecov Report

Merging #526 into 7-dev will decrease coverage by 2.37%.
The diff coverage is 87.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##            7-dev     #526      +/-   ##
==========================================
- Coverage   95.57%   93.20%   -2.38%     
==========================================
  Files          32       32              
  Lines        1311     1354      +43     
  Branches        0       85      +85     
==========================================
+ Hits         1253     1262       +9     
- Misses         58       72      +14     
- Partials        0       20      +20     
Impacted Files Coverage Δ
src/core/Room.js 100.00% <ø> (ø)
src/core/security/Role.ts 71.42% <71.42%> (ø)
src/controllers/Auth.ts 75.94% <75.94%> (ø)
src/controllers/Base.ts 88.88% <88.88%> (ø)
src/Kuzzle.ts 87.55% <100.00%> (ø)
src/controllers/Bulk.js 100.00% <100.00%> (ø)
src/controllers/Collection.js 100.00% <100.00%> (ø)
src/controllers/Document.js 95.38% <100.00%> (ø)
src/controllers/Index.js 100.00% <100.00%> (ø)
src/controllers/MemoryStorage.js 96.05% <100.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e6823...36e6649. Read the comment docs.

Aschen and others added 6 commits July 21, 2020 10:54
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
…-javascript into add-typescript-support-auth
Adds TS support for the Document controller
@Leodau Leodau merged commit 3dd7c7e into 7-dev Jul 21, 2020
@Leodau Leodau deleted the add-typescript-support-auth branch July 21, 2020 15:33
@scottinet scottinet mentioned this pull request Jul 23, 2020
scottinet added a commit that referenced this pull request Jul 23, 2020
# [7.3.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.3.0) (2020-07-23)


#### Bug fixes

- [ [#532](#532) ] Encode URI parameters when using the HTTTP protocol   ([scottinet](https://github.com/scottinet))
- [ [#516](#516) ] Fix query string construction   ([Yoann-Abbes](https://github.com/Yoann-Abbes))

#### New features

- [ [#526](#526) ] Add typescript definitions for Auth controller   ([Aschen](https://github.com/Aschen))
- [ [#524](#524) ] Support ms:mexecute   ([Leodau](https://github.com/Leodau))
- [ [#522](#522) ] Add bulk:deleteByQuery   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#519](#519) ] Add document:updateByQuery   ([Yoann-Abbes](https://github.com/Yoann-Abbes))

#### Enhancements

- [ [#517](#517) ] Add collection:update and deprecate collection:updateMapping   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
- [ [#514](#514) ] Able to execute document search as GET http method   ([Yoann-Abbes](https://github.com/Yoann-Abbes))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants