-
Notifications
You must be signed in to change notification settings - Fork 17
Add typescript definitions for Auth controller #526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #526 +/- ##
==========================================
- Coverage 95.57% 93.20% -2.38%
==========================================
Files 32 32
Lines 1311 1354 +43
Branches 0 85 +85
==========================================
+ Hits 1253 1262 +9
- Misses 58 72 +14
- Partials 0 20 +20
Continue to review full report at Codecov.
|
scottinet
suggested changes
Jul 21, 2020
scottinet
suggested changes
Jul 21, 2020
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
Co-authored-by: Sébastien Cottinet <scottinet@protonmail.com>
…-javascript into add-typescript-support-auth
scottinet
approved these changes
Jul 21, 2020
Leodau
approved these changes
Jul 21, 2020
Adds TS support for the Document controller
Merged
scottinet
added a commit
that referenced
this pull request
Jul 23, 2020
# [7.3.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.3.0) (2020-07-23) #### Bug fixes - [ [#532](#532) ] Encode URI parameters when using the HTTTP protocol ([scottinet](https://github.com/scottinet)) - [ [#516](#516) ] Fix query string construction ([Yoann-Abbes](https://github.com/Yoann-Abbes)) #### New features - [ [#526](#526) ] Add typescript definitions for Auth controller ([Aschen](https://github.com/Aschen)) - [ [#524](#524) ] Support ms:mexecute ([Leodau](https://github.com/Leodau)) - [ [#522](#522) ] Add bulk:deleteByQuery ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#519](#519) ] Add document:updateByQuery ([Yoann-Abbes](https://github.com/Yoann-Abbes)) #### Enhancements - [ [#517](#517) ] Add collection:update and deprecate collection:updateMapping ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#514](#514) ] Able to execute document search as GET http method ([Yoann-Abbes](https://github.com/Yoann-Abbes)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds Typescript support for the AuthController.
I took the descriptions from the documentation.
How should this be manually tested?
Build and pack the SDK:
npm run build && npm pack
Then init a Node project and add this dependency:
Then create a
test.ts
file with the following and try to use the controller (just for the auto-completion)Other changes
Boyscout