Add collection:update and deprecate collection:updateMapping #517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoann-Abbes
commented
May 28, 2020
Leodau
approved these changes
May 29, 2020
Aschen
suggested changes
May 29, 2020
| # updateMapping | ||
|
|
||
| <SinceBadge version="1.7.1" /> | ||
| <DeprecatedBadge version="2.1.0"/> |
There was a problem hiding this comment.
I'm not sure if this is relevant since any version of the SDK can be used with any version of Kuzzle so if I use the latest SDK version but Kuzzle v 2.0.1 this method is not deprecated.
IMHO we should keep the API deprecation in Kuzzle. Also with the deprecation module we talked about, users will receives messages from Kuzzle if they use a deprecated method in the SDK
There was a problem hiding this comment.
The method is indeed deprecated, so imo it should be documented either in SDKs
There was a problem hiding this comment.
So you should at least put version="Kuzzle 2.1.0"
Aschen
approved these changes
Jun 10, 2020
Merged
scottinet
added a commit
that referenced
this pull request
Jul 23, 2020
# [7.3.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.3.0) (2020-07-23) #### Bug fixes - [ [#532](#532) ] Encode URI parameters when using the HTTTP protocol ([scottinet](https://github.com/scottinet)) - [ [#516](#516) ] Fix query string construction ([Yoann-Abbes](https://github.com/Yoann-Abbes)) #### New features - [ [#526](#526) ] Add typescript definitions for Auth controller ([Aschen](https://github.com/Aschen)) - [ [#524](#524) ] Support ms:mexecute ([Leodau](https://github.com/Leodau)) - [ [#522](#522) ] Add bulk:deleteByQuery ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#519](#519) ] Add document:updateByQuery ([Yoann-Abbes](https://github.com/Yoann-Abbes)) #### Enhancements - [ [#517](#517) ] Add collection:update and deprecate collection:updateMapping ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#514](#514) ] Able to execute document search as GET http method ([Yoann-Abbes](https://github.com/Yoann-Abbes)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds
collection:updateto the sdk and deprecates the oldercollection:updateMapping.How should this be manually tested?
Create an index/collection and update its mapping by calling the
collection:updatemethodTests