Encode URI parameters when using the HTTTP protocol #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #532 +/- ##
==========================================
+ Coverage 91.13% 91.14% +0.01%
==========================================
Files 32 32
Lines 1387 1389 +2
Branches 129 129
==========================================
+ Hits 1264 1266 +2
Misses 98 98
Partials 25 25
Continue to review full report at Codecov.
|
alexandrebouthinon
approved these changes
Jul 23, 2020
jenow
approved these changes
Jul 23, 2020
Merged
scottinet
added a commit
that referenced
this pull request
Jul 23, 2020
# [7.3.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.3.0) (2020-07-23) #### Bug fixes - [ [#532](#532) ] Encode URI parameters when using the HTTTP protocol ([scottinet](https://github.com/scottinet)) - [ [#516](#516) ] Fix query string construction ([Yoann-Abbes](https://github.com/Yoann-Abbes)) #### New features - [ [#526](#526) ] Add typescript definitions for Auth controller ([Aschen](https://github.com/Aschen)) - [ [#524](#524) ] Support ms:mexecute ([Leodau](https://github.com/Leodau)) - [ [#522](#522) ] Add bulk:deleteByQuery ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#519](#519) ] Add document:updateByQuery ([Yoann-Abbes](https://github.com/Yoann-Abbes)) #### Enhancements - [ [#517](#517) ] Add collection:update and deprecate collection:updateMapping ([Yoann-Abbes](https://github.com/Yoann-Abbes)) - [ [#514](#514) ] Able to execute document search as GET http method ([Yoann-Abbes](https://github.com/Yoann-Abbes)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using the HTTP protocol, URI parameters are sent as-is by the SDK, which leads to invalid URLs sent when parameters contain reserved or unicode characters.
Changes
Other changes
npm run testscript was outdated: it now uses the renamed npm scripts (i.e. test:* scripts)DocumentSearchResultclass was renamedDocumentsSearchResult, which might be considered a breaking change (and is inconsistent with other *SearchResult object names anyway)