Remove "scroll" option from security:searchRoles doc #546
Conversation
Yoann-Abbes
force-pushed
the
fix-search-roles-doc
branch
from
88bb61e to
d5f8e2c
Compare
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
=======================================
Coverage 88.40% 88.40%
=======================================
Files 32 32
Lines 1449 1449
Branches 252 252
=======================================
Hits 1281 1281
Misses 119 119
Partials 49 49 Continue to review full report at Codecov.
|
|
Shouldn't this PR target 7-dev? |
I thought I wouldnt be a problem to merge it directly on master to fix this error as soon as possible. |
|
I don't see why this would be an emergency: the method isn't event documented. |
Yoann-Abbes
force-pushed
the
fix-search-roles-doc
branch
from
d5f8e2c to
2895677
Compare
Base branch changed to 7-dev |
|
Uh... so, I finally read the title, description and code of this PR. I thought this was about removing some code, not a documented option. I apologize for being an idiot. And this PR, of course, should be merged on master. 😑 |
Yoann-Abbes
force-pushed
the
fix-search-roles-doc
branch
from
2895677 to
8f7baf5
Compare
| npm ci | ||
| npm install kuzzle-sdk-v7@$TRAVIS_BUILD_DIR | ||
| cd test/e2e/run-test && npm ci && cd - | ||
| CYPRESS_RETRIES=5 npm run test:e2e |
There was a problem hiding this comment.
End 2 end tests must be run with the test:e2e command. You should change the package.json if it's not the case
There was a problem hiding this comment.
That means a PR on admin console repo kuzzleio/kuzzle-admin-console#829
What does this PR do?
Remove "scroll" option from security:searchRoles doc
Other change
Change script test name for admin console tests
depends on kuzzleio/kuzzle-admin-console#829