-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: remove py310 as guide #1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @JimmyPeilinLi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the project's user documentation to align with newer Python and dependency versions. It revises the setup instructions in both the English and Chinese fine-tuning guides, promoting Python 3.12 as the preferred environment and ensuring that the specified Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the user guides to recommend Python 3.12 instead of 3.10 and bumps the package version to 0.4.1. The changes are mostly correct, but there's an inconsistency in the English documentation where Python 3.10 is still listed as a supported version in a comment, which could confuse users. I've added a comment to address this.
| ```shell | ||
| # 1. Create a conda environment | ||
| conda create -n Kllama python=3.10 # choose from : [3.10, 3.11, 3.12, 3.13] | ||
| conda create -n Kllama python=3.12 # choose from : [3.10, 3.11, 3.12, 3.13] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment still lists Python 3.10 as a supported version, which contradicts the goal of this pull request to remove it as a guide. The Chinese version of this document has already removed 3.10 from the list. For consistency and to avoid user confusion, you should also remove it here.
| conda create -n Kllama python=3.12 # choose from : [3.10, 3.11, 3.12, 3.13] | |
| conda create -n Kllama python=3.12 # choose from : [3.11, 3.12, 3.13] |
No description provided.