Ercot product response handling#3
Merged
kvkenyon merged 1 commit intoDec 29, 2025
Merged
Conversation
Co-authored-by: kvkenyon <kvkenyon@utexas.edu>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore support for HAL and list response formats in
_products_to_dataframe.The
_products_to_dataframemethod was simplified and stopped handling HAL (_embedded.products, nestedadditional_properties._embedded.products) and raw list responses, causingget_list_for_products()to return empty DataFrames for valid API responses. This PR reintroduces logic to correctly parse these previously supported formats.Note
Reintroduces support for multiple products response shapes and strengthens test coverage.
ERCOT._products_to_dataframeto acceptAnyand correctly handle:{"products": [...]}, HAL{"_embedded": {"products": [...]}}, nested{"additional_properties": {"_embedded": {"products": [...]}}, and raw list[...]; returns empty DataFrame otherwiseWritten by Cursor Bugbot for commit df9f98f. This will update automatically on new commits. Configure here.