Skip to content

chore: clean up#63

Merged
Pertempto merged 4 commits intomainfrom
7-clean-up
Oct 24, 2025
Merged

chore: clean up#63
Pertempto merged 4 commits intomainfrom
7-clean-up

Conversation

@Pertempto
Copy link
Copy Markdown
Contributor

Final PR for #7

  • Rename things
  • Use more unique port in docker compose

@github-actions
Copy link
Copy Markdown
Contributor

Review

Summary of Changes

  • Renamed storage interface methods for consistency: SaveEvents to AddEvents, CreateApiKey to AddApiKey, etc.
  • Updated all implementations, handlers, services, and tests to use the new method names.
  • Changed docker-compose.yml port mapping to avoid conflicts (8765:8080).
  • Marked clean-up tasks as complete in specs/7-data-persistence.md.

Overall Feedback

No major issues found in this cleanup PR. The renames improve consistency across the codebase. One minor note: since this affects internal APIs, if any public documentation references the old names, it should be updated accordingly. Overall, great job on completing issue #7! 🚀

@Pertempto Pertempto merged commit 2a4aa8f into main Oct 24, 2025
2 checks passed
@Pertempto Pertempto deleted the 7-clean-up branch October 24, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant