qt: address CodeRabbit review feedback on data transactions#3
Open
thepastaclaw wants to merge 3 commits intokwvg:data_txfrom
Open
qt: address CodeRabbit review feedback on data transactions#3thepastaclaw wants to merge 3 commits intokwvg:data_txfrom
thepastaclaw wants to merge 3 commits intokwvg:data_txfrom
Conversation
Proposals are made in the form of data transactions but look like oddly shaped transactions in the UI, this should help better explain where the proposal fee went.
Replace the `class CScript;` forward declaration with a direct `#include <script/script.h>` to provide the full type definition needed by `IsDataScript`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Replace the for-loop over all vouts with a bounds-checked single access to `wtx.tx->vout[rec->idx]`, so the transaction detail view only shows the payload for the output that corresponds to this particular transaction record. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
kwvg
force-pushed
the
data_tx
branch
2 times, most recently
from
81c79d6 to
5c22389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses two review items from CodeRabbit on dashpay#7144, both confirmed by @UdjinM6:
Scope payload display to
rec->idx(transactiondesc.cpp) — The detail view is for a specificTransactionRecordpointing to outputrec->idx, but the loop was displaying payloads from everyOP_RETURNoutput. Now scoped to the specific output, which correctly handles mined transactions with multipleOP_RETURNoutputs.Replace
CScriptforward declaration with direct include (transactionrecord.h) — The inlineIsDataScriptmethod usesCScriptmethods andOP_RETURN, requiring the full definition. The forward declaration only worked due to a fragile transitive include chain.🤖 This was generated by an automated review bot.
Don't want automated PRs or comments on your code? You can opt out by replying here or messaging @PastaPastaPasta on Slack — we'll make sure the bot skips your PRs/repos going forward.