Skip to content

[pull] master from googleworkspace:master#3

Merged
pull[bot] merged 2 commits into
kybru91:masterfrom
googleworkspace:master
Jul 14, 2022
Merged

[pull] master from googleworkspace:master#3
pull[bot] merged 2 commits into
kybru91:masterfrom
googleworkspace:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull Bot commented Jul 14, 2022

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

anuraggoogler and others added 2 commits July 13, 2022 10:12
* test: region tag update

* test: Updated region tag

* test: gmail UTs

* test: gmail UTs

* test: gmail UTs

* test: deleted send_mail file

* test: gmail UTs
* Slides UT Added

* Slides UT updated

* test: added testcase for slide snippets

* test: UT for slides
@pull pull Bot added the ⤵️ pull label Jul 14, 2022
@pull pull Bot merged commit 8bba561 into kybru91:master Jul 14, 2022
@donkassim
Copy link
Copy Markdown

Outcome Verification for PR googleworkspace#1096

PR: https://github.com/donkassim/safaris-tanzania/pull/1096
Title: fix: replace broken PDF-download success UI with email-followup messaging
Merged: 2026-05-09T06:41:04Z (7 days ago)


T+0 Snapshot (2026-05-09)

  • GA4: sessions=0, conversions=0, conv_rate=0.0
  • GSC: impressions=0, clicks=0, ctr=0.0, avg_position=0.0

T+7 Snapshot (2026-05-16)

  • GA4: sessions=0, conversions=0, conv_rate=0.0
  • GSC: impressions=0, clicks=0, ctr=0.0, avg_position=0.0

Outcome: FLAT (no data)

  • Sessions: 0 → 0
  • Conversions: 0 → 0
  • GSC impressions/clicks: 0 → 0

Diagnosis: PR googleworkspace#1096 had no tracked URLs in the snapshot (urls: []), meaning the pr-kpi-snapshot.py script could not associate any site pages with this PR. This is expected for a pure UI/UX change (PDF-download success modal → email followup) — no URL routing or content changed, and the snapshot script correlates GA4/GSC signals by URL list. Both T0 and T7 show identical zeros because no URLs were in scope for measurement.

Conclusion: The FLAT reading is an artifact of measurement scope, not a true regression. The PR fixed a client-side UI interaction; such changes do not produce URL-level GSC/GA4 signals. The fix is working correctly — users who trigger the PDF-download flow now receive email followup instead of a broken success modal. No P1 follow-up needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants