APNS Broadcast Channel Management functioning#235
Closed
mattglover wants to merge 4 commits into
Closed
Conversation
Updated delete operation path to `/channels`
Error handling not touched (may require additional work)
Owner
kylebrowning
left a comment
kylebrowning
left a comment
There was a problem hiding this comment.
Code looks good. I have one question.
This also needs tests updaters but if that's too confusing I can help.
Author
Yeah, I would need to understand the testing approach and strategy here, so help would be great. |
kylebrowning
added a commit
that referenced
this pull request
Mar 26, 2026
Channel ID is now sent via apns-channel-id header instead of URL path for read/delete operations. Response body is optional since create returns only a channel ID header and delete returns 204 No Content. Channel ID moved from APNSBroadcastChannel body to APNSBroadcastResponse. Test server and tests updated to match. Based on work by @mattglover in #235.
3 tasks
kylebrowning
added a commit
that referenced
this pull request
Mar 26, 2026
Channel ID is now sent via apns-channel-id header instead of URL path for read/delete operations. Response body is optional since create returns only a channel ID header and delete returns 204 No Content. Channel ID moved from APNSBroadcastChannel body to APNSBroadcastResponse. Test server and tests updated to match. Based on work by @mattglover in #235.
kylebrowning
added a commit
that referenced
this pull request
Mar 26, 2026
* Add’s push type for Broadcast * Fix broadcast channel management to match Apple's APNs API Channel ID is now sent via apns-channel-id header instead of URL path for read/delete operations. Response body is optional since create returns only a channel ID header and delete returns 204 No Content. Channel ID moved from APNSBroadcastChannel body to APNSBroadcastResponse. Test server and tests updated to match. Based on work by @mattglover in #235.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raising a PR for discussion.
cc. @kylebrowning
Operation responses :
Status: 200 (OK)
Status: 204 (No Content)
No body
Status: 200 (OK)
Body:
Status: 200 (OK)
Body: