Skip to content

Display modal without binding element #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Display modal without binding element #172

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71d39ac
Display modal without binding element
aurelienlhx Aug 23, 2016
e6e68fd
Merge pull request #1 from aurelienlhx/aurelienlhx-patch-1
aurelienlhx Aug 23, 2016
c1b308f
Missing 1line
aurelienlhx Aug 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion jquery.modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,10 @@
};

$.modal = function(el, options) {

if(!(this instanceof $.modal))
return new $.modal(el,options);

var remove, target;
this.$body = $('body');
this.options = $.extend({}, $.modal.defaults, options);
Expand All @@ -39,7 +43,7 @@
while ($.modal.isActive())
$.modal.close(); // Close any open modals.
modals.push(this);
if (el.is('a')) {
if ((el instanceof $) && el.is('a')) {
target = el.attr('href');
//Select element by id from href
if (/^#/.test(target)) {
Expand Down Expand Up @@ -71,6 +75,8 @@
});
}
} else {
if(!(el instanceof $))
el = $(document.createElement('div')).html(el);
this.$elm = el;
this.$body.append(this.$elm);
this.open();
Expand Down